Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use explicit data types with pandas #42

Open
lukasauer opened this issue Feb 14, 2022 · 2 comments
Open

Use explicit data types with pandas #42

lukasauer opened this issue Feb 14, 2022 · 2 comments

Comments

@lukasauer
Copy link
Member

Pandas may sometimes choose to convert large integers (close to 64-bit integer limit) to floats. This is very common on register dataset on 64-bit architecture and is fixed with #41. Similar situation in the code base should be fixed as well. This problem is likely to also occur if a target binary is mapped to a negative memory address (typical for kernels).
@tibersam
Copy link
Collaborator

Just out of interest: is it negative because the memory address is a unsigned address value interpreted as a signed?

@lukasauer
Copy link
Member Author

No, the addresses are always interpreted correctly. I am not sure what the underlying problem is. Could be because there are mixed data types (signed and unsigned integers in this case) in the pandas data structure.

lukasauer added a commit to lukasauer/archie that referenced this issue Aug 2, 2022
@lukasauer
Fix unintended cast of large integer registers to floats
0d9ebc2 
The call to pandas.concat in write_output_wrt_goldenrun() causes large
integer registers values to be cast to floats. Since the register values
do not have to be deduplicated, do not process them with
write_output_wrt_goldenrun().

See also Fraunhofer-AISEC#41 and Fraunhofer-AISEC#42
@lukasauer lukasauer mentioned this issue Aug 2, 2022
Merged
lukasauer added a commit that referenced this issue Aug 11, 2022
@lukasauer
Fix unintended cast of large integer registers to floats
019b0fd 
The call to pandas.concat in write_output_wrt_goldenrun() causes large
integer registers values to be cast to floats. Since the register values
do not have to be deduplicated, do not process them with
write_output_wrt_goldenrun().

See also #41 and #42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lukasauer @tibersam