Fixed issue with chinese conversion for new pilot

FrancescoE · Oct 17, 2018 · f2ab582 · f2ab582
1 parent c98382f
commit f2ab582
Showing 1 changed file with 18 additions and 5 deletions.
diff --git a/lib/Features/Microsoft.php b/lib/Features/Microsoft.php
@@ -28,6 +28,8 @@ class Microsoft extends BaseFeature {
 
     const FEATURE_CODE = "microsoft";
 
+    protected $logger_name = self::FEATURE_CODE;
+
     public static $dependencies = [
             Features::PROJECT_COMPLETION,
             Features::TRANSLATION_VERSIONS,
@@ -313,15 +315,22 @@ public function overrideReviseJobQA( $jobQA, $id_job, $password_job, $job_words
 
     /**
      * Because of a bug in filters we force languages conversion to it-IT when isCJK
-     * @param array $array
      *
-     * @return array
+     * @param string $language
+     * @param string $filePath
+     *
+     * @return string
      */
-    public function overrideConversionRequest( $language ){
-        if( \CatUtils::isCJK( $language ) ){
-            $language = 'it-IT';
+    public function changeXliffTargetLangCode( $language, $filePath ){
+
+        if( $this->needsConversion( $filePath ) ){
+            if( \CatUtils::isCJK( $language ) ){
+                $language = 'it-IT';
+            }
         }
+
         return $language;
+
     }
 
     public function overrideConversionResult( $documentContent, $language ){
@@ -343,6 +352,10 @@ public function forceXLIFFConversion( $forceXliff, $_userIsLogged, $xliffPath )
         if( !$_userIsLogged ) {
             return $forceXliff;
         }
+        return $this->needsConversion( $xliffPath );
+    }
+
+    private function needsConversion( $xliffPath ){
         $fileInfo = \DetectProprietaryXliff::isXliff( null, $xliffPath );
         if ( isset( $fileInfo[ 0 ] ) ) {
             preg_match( '#tool-id\s*=\s*"mdxliff"#i', $fileInfo[ 0 ], $matches );