Moved flask app out of global space, moved routes to a class, updated… #277
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This does not resolve the overall issue I was looking to fix with the improper shutdown but that will be forthcoming shortly in another PR after this is merged in. Trying to keep this in smaller chunks as much as I can. |
This comment was marked as duplicate.
This comment was marked as duplicate.
Sorry, something went wrong.
sparklestheunicorn
requested review from
mike-kiss
and removed request for
mike-kiss
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… related calls
TL;DR
Quick summary/list of your change(s)
What
What is affected by this PR?
Testing
How was this tested?
Tested the usual way, unit tests pass and also through the UI.
Figured I'd start with getting the changes in with a relatively small set initially, the routes.py changes look more intimidating than they are: moved the routes to a class to move more out of global space, maybe not required but with the recent difficulty we had the more out of global space the better.