Electron upgrade to 14.2.1 #2357
Conversation
- Remove the electron-spelllchecker package as it does not work anymore - Remove the spellchecker temporarily - Manually set enableRemoteModule to true
This fixes builds on newer Linux systems
bump electron 12.2.3
On my Ubuntu 20.10 some of these tests currently fail as words cannot be learned. Needs some mor debugging.
Phylu
changed the title
|
Hi @Phylu . I'm testing this branch for a few days. Works pretty good for me. No issues so far. |
|
This pull request has been mentioned on Mailspring Community. There might be relevant details there: https://community.getmailspring.com/t/pdf-printing-broken/1750/13 |
|
Anything needed in the snap? |
|
@bengotow Did you have some time for testing already? :) |
|
Ok - I had to make AppVeyor and TravisCI use Node 16 and Visual Studio 2017 on Windows, but we've got builds! 🙌 I couldn't get I'm going to continue testing these tomorrow and ship them after lunch if everything looks good. At this point I think it'd be better to release and then quickly fix anything that is broken since I've been sitting on this for so long. 🤦♂️ Thank you for spearheading this + tracking down and fixing the bugs @Phylu! I made a Mailspring-Maintainers group and added you so that you have push access to the entire repository and can merge PRs that look good. I think that will also let you trigger builds on Travis (to test things like this more easily) by logging in via Github at https://app.travis-ci.com/github/Foundry376/Mailspring. Beta builds: MacOS: Windows: Linux: |
|
The macOS build still seems to be an x86 application for some reason. |
The Travis build currently only creates an amd64 package. It is not compiled for arm64 yet. |
|
Hey folks! Yep still an intel build for now. We could make it a universal binary but it would double the size to 600MB. I think we need to update the download page to offer both versions and the auto-updater needs to get the correct architecture for updates. Will see if I can update it this weekend! |
|
Hey @bengotow! Not to be a pain but would you mind giving us an update? |
|
This pull request has been mentioned on Mailspring Community. There might be relevant details there: https://community.getmailspring.com/t/spellcheck-broken-on-windows-11/5269/4 |
Closes #2352