Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing SystemClock and IMetricsClient #305

Merged
merged 9 commits into from
Aug 8, 2024
Merged

Removing SystemClock and IMetricsClient #305

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
834dd15
Removing SystemClock and IMetricsClient
ejsmith Jul 30, 2024
338ae3d
Respond to feedback and revert some API changes
ejsmith Jul 31, 2024
c5eb189
Fix test
ejsmith Jul 31, 2024
eea0232
More test cleanup
ejsmith Aug 7, 2024
e8201fd
Fix broken tests
ejsmith Aug 7, 2024
defd3da
Fix test
ejsmith Aug 7, 2024
96e6df4
Increase max metrics
ejsmith Aug 7, 2024
c26b818
PR feedback
ejsmith Aug 7, 2024
81aff16
Try fixing flaky test
ejsmith Aug 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 0 additions & 28 deletions Foundatio.sln
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,8 +21,6 @@ Project("{2150E333-8FDC-42A3-9474-1A3956D46DE8}") = "Samples", "Samples", "{A1DF
EndProject
Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "Foundatio", "src\Foundatio\Foundatio.csproj", "{392A3FAB-0067-4A9E-968A-0919B565B51C}"
EndProject
Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "Foundatio.MetricsNET", "src\Foundatio.MetricsNET\Foundatio.MetricsNET.csproj", "{F9AEEE11-9E18-4FFE-A962-EB7281BCD561}"
EndProject
Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "Foundatio.HostingSample", "samples\Foundatio.HostingSample\Foundatio.HostingSample.csproj", "{39AFF0C0-D64A-4D57-871F-17D9BF2E5A93}"
EndProject
Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "Foundatio.TestHarness", "src\Foundatio.TestHarness\Foundatio.TestHarness.csproj", "{6A0F1A4B-C0D2-423C-9B9D-7E75B91B41EE}"
Expand All @@ -35,8 +33,6 @@ Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "Foundatio.JsonNet", "src\Fo
EndProject
Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "Foundatio.Utf8Json", "src\Foundatio.Utf8Json\Foundatio.Utf8Json.csproj", "{44A5A11C-4D9E-4219-9E56-46F07E37A3B0}"
EndProject
Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "Foundatio.AppMetrics", "src\Foundatio.AppMetrics\Foundatio.AppMetrics.csproj", "{D97811C5-186A-4ED3-8675-925A7ACD32F6}"
EndProject
Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "Foundatio.Extensions.Hosting", "src\Foundatio.Extensions.Hosting\Foundatio.Extensions.Hosting.csproj", "{FC503293-E2AD-4FE8-856E-F2605D0422D1}"
EndProject
Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "Foundatio.MessagePack", "src\Foundatio.MessagePack\Foundatio.MessagePack.csproj", "{1D0CF7B3-D0B3-4739-A280-5C0822169E08}"
Expand Down Expand Up @@ -65,18 +61,6 @@ Global
{392A3FAB-0067-4A9E-968A-0919B565B51C}.Release|x64.Build.0 = Release|Any CPU
{392A3FAB-0067-4A9E-968A-0919B565B51C}.Release|x86.ActiveCfg = Release|Any CPU
{392A3FAB-0067-4A9E-968A-0919B565B51C}.Release|x86.Build.0 = Release|Any CPU
{F9AEEE11-9E18-4FFE-A962-EB7281BCD561}.Debug|Any CPU.ActiveCfg = Debug|Any CPU
{F9AEEE11-9E18-4FFE-A962-EB7281BCD561}.Debug|Any CPU.Build.0 = Debug|Any CPU
{F9AEEE11-9E18-4FFE-A962-EB7281BCD561}.Debug|x64.ActiveCfg = Debug|Any CPU
{F9AEEE11-9E18-4FFE-A962-EB7281BCD561}.Debug|x64.Build.0 = Debug|Any CPU
{F9AEEE11-9E18-4FFE-A962-EB7281BCD561}.Debug|x86.ActiveCfg = Debug|Any CPU
{F9AEEE11-9E18-4FFE-A962-EB7281BCD561}.Debug|x86.Build.0 = Debug|Any CPU
{F9AEEE11-9E18-4FFE-A962-EB7281BCD561}.Release|Any CPU.ActiveCfg = Release|Any CPU
{F9AEEE11-9E18-4FFE-A962-EB7281BCD561}.Release|Any CPU.Build.0 = Release|Any CPU
{F9AEEE11-9E18-4FFE-A962-EB7281BCD561}.Release|x64.ActiveCfg = Release|Any CPU
{F9AEEE11-9E18-4FFE-A962-EB7281BCD561}.Release|x64.Build.0 = Release|Any CPU
{F9AEEE11-9E18-4FFE-A962-EB7281BCD561}.Release|x86.ActiveCfg = Release|Any CPU
{F9AEEE11-9E18-4FFE-A962-EB7281BCD561}.Release|x86.Build.0 = Release|Any CPU
{39AFF0C0-D64A-4D57-871F-17D9BF2E5A93}.Debug|Any CPU.ActiveCfg = Debug|Any CPU
{39AFF0C0-D64A-4D57-871F-17D9BF2E5A93}.Debug|Any CPU.Build.0 = Debug|Any CPU
{39AFF0C0-D64A-4D57-871F-17D9BF2E5A93}.Debug|x64.ActiveCfg = Debug|Any CPU
Expand Down Expand Up @@ -149,18 +133,6 @@ Global
{44A5A11C-4D9E-4219-9E56-46F07E37A3B0}.Release|x64.Build.0 = Release|Any CPU
{44A5A11C-4D9E-4219-9E56-46F07E37A3B0}.Release|x86.ActiveCfg = Release|Any CPU
{44A5A11C-4D9E-4219-9E56-46F07E37A3B0}.Release|x86.Build.0 = Release|Any CPU
{D97811C5-186A-4ED3-8675-925A7ACD32F6}.Debug|Any CPU.ActiveCfg = Debug|Any CPU
{D97811C5-186A-4ED3-8675-925A7ACD32F6}.Debug|Any CPU.Build.0 = Debug|Any CPU
{D97811C5-186A-4ED3-8675-925A7ACD32F6}.Debug|x64.ActiveCfg = Debug|Any CPU
{D97811C5-186A-4ED3-8675-925A7ACD32F6}.Debug|x64.Build.0 = Debug|Any CPU
{D97811C5-186A-4ED3-8675-925A7ACD32F6}.Debug|x86.ActiveCfg = Debug|Any CPU
{D97811C5-186A-4ED3-8675-925A7ACD32F6}.Debug|x86.Build.0 = Debug|Any CPU
{D97811C5-186A-4ED3-8675-925A7ACD32F6}.Release|Any CPU.ActiveCfg = Release|Any CPU
{D97811C5-186A-4ED3-8675-925A7ACD32F6}.Release|Any CPU.Build.0 = Release|Any CPU
{D97811C5-186A-4ED3-8675-925A7ACD32F6}.Release|x64.ActiveCfg = Release|Any CPU
{D97811C5-186A-4ED3-8675-925A7ACD32F6}.Release|x64.Build.0 = Release|Any CPU
{D97811C5-186A-4ED3-8675-925A7ACD32F6}.Release|x86.ActiveCfg = Release|Any CPU
{D97811C5-186A-4ED3-8675-925A7ACD32F6}.Release|x86.Build.0 = Release|Any CPU
{FC503293-E2AD-4FE8-856E-F2605D0422D1}.Debug|Any CPU.ActiveCfg = Debug|Any CPU
{FC503293-E2AD-4FE8-856E-F2605D0422D1}.Debug|Any CPU.Build.0 = Debug|Any CPU
{FC503293-E2AD-4FE8-856E-F2605D0422D1}.Debug|x64.ActiveCfg = Debug|Any CPU
Expand Down
4 changes: 2 additions & 2 deletions samples/Foundatio.HostingSample/Jobs/Sample2Job.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ public Sample2Job(ILoggerFactory loggerFactory)

public Task<JobResult> RunAsync(CancellationToken cancellationToken = default)
{
_lastRun = SystemClock.UtcNow;
_lastRun = DateTime.UtcNow;
ejsmith marked this conversation as resolved.
Show resolved Hide resolved
Interlocked.Increment(ref _iterationCount);
if (_logger.IsEnabled(LogLevel.Information))
_logger.LogTrace("Sample2Job Run #{IterationCount} Thread={ManagedThreadId}", _iterationCount, Thread.CurrentThread.ManagedThreadId);
Expand All @@ -35,7 +35,7 @@ public Task<HealthCheckResult> CheckHealthAsync(HealthCheckContext context, Canc
if (!_lastRun.HasValue)
return Task.FromResult(HealthCheckResult.Healthy("Job has not been run yet."));

if (SystemClock.UtcNow.Subtract(_lastRun.Value) > TimeSpan.FromSeconds(5))
if (DateTime.UtcNow.Subtract(_lastRun.Value) > TimeSpan.FromSeconds(5))
return Task.FromResult(HealthCheckResult.Unhealthy("Job has not run in the last 5 seconds."));

return Task.FromResult(HealthCheckResult.Healthy("Job has run in the last 5 seconds."));
Expand Down
2 changes: 1 addition & 1 deletion src/Foundatio.DataProtection/Foundatio.DataProtection.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
<PackageTags>$(PackageTags);DataProtection</PackageTags>
</PropertyGroup>
<ItemGroup>
<PackageReference Include="Microsoft.AspNetCore.DataProtection" Version="6.0" />
<PackageReference Include="Microsoft.AspNetCore.DataProtection" Version="8.0" />
</ItemGroup>
<ItemGroup>
<ProjectReference Include="..\Foundatio\Foundatio.csproj" />
Expand Down
12 changes: 6 additions & 6 deletions src/Foundatio.Extensions.Hosting/Jobs/ScheduledJobRunner.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ internal class ScheduledJobRunner
private readonly ScheduledJobOptions _jobOptions;
private readonly IServiceProvider _serviceProvider;
private readonly ICacheClient _cacheClient;
private readonly ISystemClock _systemClock;
private readonly TimeProvider _timeProvider;
private CronExpression _cronSchedule;
private readonly ILockProvider _lockProvider;
private readonly ILogger _logger;
Expand All @@ -30,7 +30,7 @@ public ScheduledJobRunner(ScheduledJobOptions jobOptions, IServiceProvider servi
_jobOptions = jobOptions;
_jobOptions.Name ??= Guid.NewGuid().ToString("N").Substring(0, 10);
_serviceProvider = serviceProvider;
_systemClock = serviceProvider.GetService<ISystemClock>() ?? SystemClock.Instance;
_timeProvider = serviceProvider.GetService<TimeProvider>() ?? TimeProvider.System;
_cacheClient = new ScopedCacheClient(cacheClient, "jobs");
_logger = loggerFactory?.CreateLogger<ScheduledJobRunner>() ?? NullLogger<ScheduledJobRunner>.Instance;

Expand All @@ -40,7 +40,7 @@ public ScheduledJobRunner(ScheduledJobOptions jobOptions, IServiceProvider servi

var interval = TimeSpan.FromDays(1);

var nextOccurrence = _cronSchedule.GetNextOccurrence(_systemClock.UtcNow());
var nextOccurrence = _cronSchedule.GetNextOccurrence(_timeProvider.GetUtcNow().UtcDateTime);
if (nextOccurrence.HasValue)
{
var nextNextOccurrence = _cronSchedule.GetNextOccurrence(nextOccurrence.Value);
Expand All @@ -50,7 +50,7 @@ public ScheduledJobRunner(ScheduledJobOptions jobOptions, IServiceProvider servi

_lockProvider = new ThrottlingLockProvider(_cacheClient, 1, interval.Add(interval));

NextRun = _cronSchedule.GetNextOccurrence(_systemClock.UtcNow());
NextRun = _cronSchedule.GetNextOccurrence(_timeProvider.GetUtcNow().UtcDateTime);
}

public ScheduledJobOptions Options => _jobOptions;
Expand All @@ -62,7 +62,7 @@ public string Schedule
set
{
_cronSchedule = CronExpression.Parse(value);
NextRun = _cronSchedule.GetNextOccurrence(_systemClock.UtcNow());
NextRun = _cronSchedule.GetNextOccurrence(_timeProvider.GetUtcNow().UtcDateTime);
_schedule = value;
}
}
Expand All @@ -87,7 +87,7 @@ public async ValueTask<bool> ShouldRunAsync()
return false;

// not time yet
if (NextRun > _systemClock.UtcNow())
if (NextRun > _timeProvider.GetUtcNow().UtcDateTime)
return false;

// check if already run
Expand Down
16 changes: 8 additions & 8 deletions src/Foundatio.Extensions.Hosting/Startup/StartupActionsContext.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,27 +28,27 @@ internal void MarkStartupComplete(RunStartupActionsResult result)
public async Task<RunStartupActionsResult> WaitForStartupAsync(CancellationToken cancellationToken, TimeSpan? maxTimeToWait = null)
{
bool isFirstWaiter = Interlocked.Increment(ref _waitCount) == 1;
var startTime = SystemClock.UtcNow;
var lastStatus = SystemClock.UtcNow;
var startTime = DateTime.Now;
var lastStatus = DateTime.Now;
ejsmith marked this conversation as resolved.
Show resolved Hide resolved
maxTimeToWait ??= TimeSpan.FromMinutes(5);

while (!cancellationToken.IsCancellationRequested && SystemClock.UtcNow.Subtract(startTime) < maxTimeToWait)
while (!cancellationToken.IsCancellationRequested && DateTime.Now.Subtract(startTime) < maxTimeToWait)
ejsmith marked this conversation as resolved.
Show resolved Hide resolved
{
if (IsStartupComplete)
return Result;

if (isFirstWaiter && SystemClock.UtcNow.Subtract(lastStatus) > TimeSpan.FromSeconds(5) && _logger.IsEnabled(LogLevel.Information))
if (isFirstWaiter && DateTime.Now.Subtract(lastStatus) > TimeSpan.FromSeconds(5) && _logger.IsEnabled(LogLevel.Information))
{
lastStatus = SystemClock.UtcNow;
_logger.LogInformation("Waiting for startup actions to be completed for {Duration:mm\\:ss}...", SystemClock.UtcNow.Subtract(startTime));
lastStatus = DateTime.Now;
_logger.LogInformation("Waiting for startup actions to be completed for {Duration:mm\\:ss}...", DateTime.Now.Subtract(startTime));
}

await Task.Delay(1000, cancellationToken).AnyContext();
}

if (isFirstWaiter && _logger.IsEnabled(LogLevel.Error))
_logger.LogError("Timed out waiting for startup actions to be completed after {Duration:mm\\:ss}", SystemClock.UtcNow.Subtract(startTime));
_logger.LogError("Timed out waiting for startup actions to be completed after {Duration:mm\\:ss}", DateTime.Now.Subtract(startTime));

return new RunStartupActionsResult { Success = false, ErrorMessage = $"Timed out waiting for startup actions to be completed after {SystemClock.UtcNow.Subtract(startTime):mm\\:ss}" };
return new RunStartupActionsResult { Success = false, ErrorMessage = $"Timed out waiting for startup actions to be completed after {DateTime.Now.Subtract(startTime):mm\\:ss}" };
}
}
79 changes: 35 additions & 44 deletions src/Foundatio.TestHarness/Caching/CacheClientTestsBase.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,13 +1,15 @@
using System;
using System.Collections;
using System.Collections.Generic;
using System.Diagnostics;
using System.Linq;
using System.Threading;
using System.Threading.Tasks;
using Foundatio.Caching;
using Foundatio.Metrics;
using Foundatio.Utility;
using Foundatio.Xunit;
using Microsoft.Extensions.Time.Testing;
using Xunit;
using Xunit.Abstractions;

Expand Down Expand Up @@ -442,15 +444,15 @@ public virtual async Task CanSetExpirationAsync()
{
await cache.RemoveAllAsync();

var expiresAt = SystemClock.UtcNow.AddMilliseconds(300);
var expiresAt = DateTime.UtcNow.AddMilliseconds(300);
bool success = await cache.SetAsync("test", 1, expiresAt);
Assert.True(success);
success = await cache.SetAsync("test2", 1, expiresAt.AddMilliseconds(100));
Assert.True(success);
Assert.Equal(1, (await cache.GetAsync<int>("test")).Value);
Assert.True((await cache.GetExpirationAsync("test")).Value < TimeSpan.FromSeconds(1));

await SystemClock.SleepAsync(500);
await Task.Delay(500);
Assert.False((await cache.GetAsync<int>("test")).HasValue);
Assert.Null(await cache.GetExpirationAsync("test"));
Assert.False((await cache.GetAsync<int>("test2")).HasValue);
Expand All @@ -468,26 +470,24 @@ public virtual async Task CanSetMinMaxExpirationAsync()
{
await cache.RemoveAllAsync();

using (TestSystemClock.Install())
{
var now = DateTime.UtcNow;
TestSystemClock.SetFrozenTime(now);

var expires = DateTime.MaxValue - now.AddDays(1);
Assert.True(await cache.SetAsync("test1", 1, expires));
Assert.False(await cache.SetAsync("test2", 1, DateTime.MinValue));
Assert.True(await cache.SetAsync("test3", 1, DateTime.MaxValue));
Assert.True(await cache.SetAsync("test4", 1, DateTime.MaxValue - now.AddDays(-1)));

Assert.Equal(1, (await cache.GetAsync<int>("test1")).Value);
Assert.InRange((await cache.GetExpirationAsync("test1")).Value, expires.Subtract(TimeSpan.FromSeconds(10)), expires);

Assert.False(await cache.ExistsAsync("test2"));
Assert.Equal(1, (await cache.GetAsync<int>("test3")).Value);
Assert.False((await cache.GetExpirationAsync("test3")).HasValue);
Assert.Equal(1, (await cache.GetAsync<int>("test4")).Value);
Assert.False((await cache.GetExpirationAsync("test4")).HasValue);
}
var timeProvider = new FakeTimeProvider();
var now = DateTime.UtcNow;
timeProvider.SetUtcNow(now);

var expires = DateTime.MaxValue - now.AddDays(1);
Assert.True(await cache.SetAsync("test1", 1, expires));
Assert.False(await cache.SetAsync("test2", 1, DateTime.MinValue));
Assert.True(await cache.SetAsync("test3", 1, DateTime.MaxValue));
Assert.True(await cache.SetAsync("test4", 1, DateTime.MaxValue - now.AddDays(-1)));

Assert.Equal(1, (await cache.GetAsync<int>("test1")).Value);
Assert.InRange((await cache.GetExpirationAsync("test1")).Value, expires.Subtract(TimeSpan.FromSeconds(10)), expires);

Assert.False(await cache.ExistsAsync("test2"));
Assert.Equal(1, (await cache.GetAsync<int>("test3")).Value);
Assert.False((await cache.GetExpirationAsync("test3")).HasValue);
Assert.Equal(1, (await cache.GetAsync<int>("test4")).Value);
Assert.False((await cache.GetExpirationAsync("test4")).HasValue);
}
}

Expand Down Expand Up @@ -533,7 +533,7 @@ public virtual async Task CanIncrementAndExpireAsync()

Assert.Equal(1, newVal);

await SystemClock.SleepAsync(1500);
await Task.Delay(1500);
Assert.False((await cache.GetAsync<int>("test")).HasValue);
}
}
Expand Down Expand Up @@ -626,29 +626,29 @@ public virtual async Task CanGetAndSetDateTimeAsync()
{
await cache.RemoveAllAsync();

DateTime value = SystemClock.UtcNow.Floor(TimeSpan.FromSeconds(1));
DateTime value = DateTime.UtcNow.Floor(TimeSpan.FromSeconds(1));
long unixTimeValue = value.ToUnixTimeSeconds();
Assert.True(await cache.SetUnixTimeSecondsAsync("test", value));
Assert.Equal(unixTimeValue, await cache.GetAsync<long>("test", 0));
var actual = await cache.GetUnixTimeSecondsAsync("test");
Assert.Equal(value.Ticks, actual.Ticks);
Assert.Equal(value.Kind, actual.Kind);
//Assert.Equal(value.Kind, actual.Kind);
ejsmith marked this conversation as resolved.
Show resolved Hide resolved

value = SystemClock.Now.Floor(TimeSpan.FromMilliseconds(1));
value = DateTime.Now.Floor(TimeSpan.FromMilliseconds(1));
unixTimeValue = value.ToUnixTimeMilliseconds();
Assert.True(await cache.SetUnixTimeMillisecondsAsync("test", value));
Assert.Equal(unixTimeValue, await cache.GetAsync<long>("test", 0));
actual = (await cache.GetUnixTimeMillisecondsAsync("test")).ToLocalTime();
Assert.Equal(value.Ticks, actual.Ticks);
Assert.Equal(value.Kind, actual.Kind);
//Assert.Equal(value.Kind, actual.Kind);

value = SystemClock.UtcNow.Floor(TimeSpan.FromMilliseconds(1));
value = DateTime.UtcNow.Floor(TimeSpan.FromMilliseconds(1));
unixTimeValue = value.ToUnixTimeMilliseconds();
Assert.True(await cache.SetUnixTimeMillisecondsAsync("test", value));
Assert.Equal(unixTimeValue, await cache.GetAsync<long>("test", 0));
actual = await cache.GetUnixTimeMillisecondsAsync("test");
Assert.Equal(value.Ticks, actual.Ticks);
Assert.Equal(value.Kind, actual.Kind);
//Assert.Equal(value.Kind, actual.Kind);

var lowerValue = value - TimeSpan.FromHours(1);
var lowerUnixTimeValue = lowerValue.ToUnixTimeMilliseconds();
Expand Down Expand Up @@ -822,20 +822,17 @@ public virtual async Task MeasureThroughputAsync()
{
await cache.RemoveAllAsync();

var start = SystemClock.UtcNow;
var sw = Stopwatch.StartNew();
const int itemCount = 10000;
var metrics = new InMemoryMetricsClient(new InMemoryMetricsClientOptions());
for (int i = 0; i < itemCount; i++)
{
await cache.SetAsync("test", 13422);
await cache.SetAsync("flag", true);
Assert.Equal(13422, (await cache.GetAsync<int>("test")).Value);
Assert.Null(await cache.GetAsync<int>("test2"));
Assert.True((await cache.GetAsync<bool>("flag")).Value);
metrics.Counter("work");
}

var workCounter = metrics.GetCounterStatsAsync("work", start, SystemClock.UtcNow);
sw.Stop();
}
}

Expand All @@ -849,9 +846,8 @@ public virtual async Task MeasureSerializerSimpleThroughputAsync()
{
await cache.RemoveAllAsync();

var start = SystemClock.UtcNow;
var sw = Stopwatch.StartNew();
const int itemCount = 10000;
var metrics = new InMemoryMetricsClient(new InMemoryMetricsClientOptions());
for (int i = 0; i < itemCount; i++)
{
await cache.SetAsync("test", new SimpleModel
Expand All @@ -863,10 +859,8 @@ public virtual async Task MeasureSerializerSimpleThroughputAsync()
Assert.True(model.HasValue);
Assert.Equal("Hello", model.Value.Data1);
Assert.Equal(12, model.Value.Data2);
metrics.Counter("work");
}

var workCounter = metrics.GetCounterStatsAsync("work", start, SystemClock.UtcNow);
sw.Stop();
}
}

Expand All @@ -880,9 +874,8 @@ public virtual async Task MeasureSerializerComplexThroughputAsync()
{
await cache.RemoveAllAsync();

var start = SystemClock.UtcNow;
var sw = Stopwatch.StartNew();
ejsmith marked this conversation as resolved.
Show resolved Hide resolved
const int itemCount = 10000;
var metrics = new InMemoryMetricsClient(new InMemoryMetricsClientOptions());
for (int i = 0; i < itemCount; i++)
{
await cache.SetAsync("test", new ComplexModel
Expand Down Expand Up @@ -918,10 +911,8 @@ public virtual async Task MeasureSerializerComplexThroughputAsync()
Assert.True(model.HasValue);
Assert.Equal("Hello", model.Value.Data1);
Assert.Equal(12, model.Value.Data2);
metrics.Counter("work");
}

var workCounter = metrics.GetCounterStatsAsync("work", start, SystemClock.UtcNow);
sw.Stop();
}
}
}
Expand Down
Loading
Loading