better fix on color filtering long click

ForwardFeed · Apr 26, 2024 · f758d1e · f758d1e
1 parent a97bbdd
commit f758d1e
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 5 deletions.
diff --git a/static/js/filters.js b/static/js/filters.js
@@ -708,8 +708,7 @@ export function setupFilters(){
     setLongClickSelection($('#to-filter')[0], ()=>{
         removeAllFilters()
         // remove a color bug on previously added filters buttons
-        $('.extend').not("#to-filter *").css("backgroundColor", "green")
-    })
+    }, ()=>{return "red"})
 
     setupFiltersRow()
 }
@@ -737,7 +736,7 @@ export function longClickToFilter(panelID, node, key, data = ()=>{return node.in
         activateSearch()
         extendableDiv.style.backgroundColor = color
         if (callback) callback()
-    }, 450, hasFilter(key, data(), panelID) ? "red" : "green")
+    },()=>{return hasFilter(key, data(), panelID) ? "red" : "green" }, 450)
 }
 
 function setupFiltersRow(){

diff --git a/static/js/utils.js b/static/js/utils.js
@@ -126,9 +126,9 @@ export function JSHAC(htmlArray){
     return frag
 }
 
-export function setLongClickSelection(node, callback, time = 500, bgColor = "red"){
+export function setLongClickSelection(node, callback, colorCb, time = 500){
     const extendableDiv  = e("div", "extend")
-    extendableDiv.style.backgroundColor = bgColor
+    extendableDiv.style.backgroundColor = colorCb()
     extendableDiv.style.display = "none"
     node.append(extendableDiv)
     node.style.position = "relative"
@@ -146,6 +146,7 @@ export function setLongClickSelection(node, callback, time = 500, bgColor = "red
             hasFired = true
             callback()
         }, time)
+        extendableDiv.style.backgroundColor = colorCb()
         extendableDiv.animate([
             { width: "0%"},
             { width: "100%"},