New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added add-fgtfirewallservicecustom #266

Open

Joeym0180 wants to merge 1 commit into FortiPower:master from joeymeijer:master

Joeym0180 commented Sep 14, 2024

This would be really helpful to have,

If you miss something in the new function just let me know what to add. or fix it to fit the module.

Function can be expanded with more options. but the basic needs are in there i guess.


          added add-fgtfirewallservicecustom

78b1dd5

Contributor

alagoutte commented Sep 15, 2024

Thanks for contribution ! but missing some stuff..
you code don't really use module code style (look other file)

and also need to have some Tests (look Tests/integration folder)

there is already a draft PR about support service custom (#204)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet