Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: work on dns database #134

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

WIP: work on dns database #134

wants to merge 1 commit into from

Conversation

jelmerj
Copy link
Contributor

@jelmerj jelmerj commented Jan 8, 2021

No description provided.

Copy link
Contributor

@alagoutte alagoutte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look good for first draft

need to add remove function too

and some tests ;-)

@@ -0,0 +1,185 @@
#
# Copyright 2019, Alexis La Goutte <alexis dot lagoutte at gmail dot com>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

May be need also to update my copyright year ;)

}

function Add-FGTSystemDnsZone {
[CmdletBinding(SupportsShouldProcess)]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add .SYNOPSIS/.DESCRIPTION/.EXAMPLE,

[ValidateSet('master', 'slave')]
[string]$type = "master",
[Parameter(Mandatory = $false)]
[ValidateSet('shadow', 'public')]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not case sensible ?

[ValidateLength(1, 255)]
[string]$domainname,
[Parameter(Mandatory = $false)]
[ValidateScript( { $_ -match [IPAddress]$_ })]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use type IPAddress ? (and after $allowtransfer.ToString() for get IPv4 display

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants