Clear(er) structure in App #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
========================== Remove unnecessary code from App.tsx Improve semantic structure of App.tsx
=========================================== Restructure Block(s) to remove redundant div. Add 'temporary' marginBottom override to Block to emulate previous feel.
========================================== Create a new group button was wrapped by a React-Router-Dom.Link component, which renders an anchor; however, so does the button component. This caused a strange unnecessary anchor inside an anchor. Solution: remove the Link component and use the button component directly to call the navigate function in React-Router-Dom instead.
=========================== Out going algo is unnecessarily loopy. Random already generates a long enough number. NB: Still high collision chance, but good enough for now.
======================= Add input for group id Add button to join group Add ux to disable button/link when group id is not provided
|
@XavierMod Because I'm super rusty at git I've managed to mess up this PR with non related code. The last push added code concerning join existing group. This should be in a separate PR, sorry! |
================ Add disabled prop to Button component
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@XavierMod
Remove unnecessary code from App.tsx
Improve semantic structure of App.tsx