Fix #790 order of parameters for register on iOS
#804
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tudormarze
changed the title
register on iOSregister on iOS
|
Bumping this to see if the plan is for it to be merged? I'm running into the same error referenced in #790. |
|
Bumping this again for visibility, still seeing the issue referenced in #790 |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #790 IOS Register method ::: Argument 7 (double) of RNAppAuth.register must not be null
Description
Unifies the order of parameters for
registerso they are the same in JS, iOS and Android. JS and Android had the same order so I assumed it's best to change in iOS.Steps to verify
Was unable to verify with the current state of
mainas there are other errorsCould be tested by calling
await register(registerConfig)on both iOS and Android and making sure there are no crashes