-
Notifications
You must be signed in to change notification settings - Fork 441
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(macos): support react-native-macos #1002
Open
shirakaba
wants to merge
15
commits into
FormidableLabs:main
Choose a base branch
from
scoville:feat/macos/support-react-native-macos
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
feat(macos): support react-native-macos #1002
shirakaba
wants to merge
15
commits into
FormidableLabs:main
from
scoville:feat/macos/support-react-native-macos
Commits on Oct 30, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 25abcf6 - Browse repository at this point
Copy the full SHA 25abcf6View commit details -
fix: stop
yarn install
from throwing 'expected workspace package to…… exist for "eslint"' error yarnpkg/yarn#8405
Configuration menu - View commit details
-
Copy full SHA for c2d4ee4 - Browse repository at this point
Copy the full SHA c2d4ee4View commit details -
Configuration menu - View commit details
-
Copy full SHA for ee514fc - Browse repository at this point
Copy the full SHA ee514fcView commit details -
Configuration menu - View commit details
-
Copy full SHA for a8190d3 - Browse repository at this point
Copy the full SHA a8190d3View commit details -
feat: migrate to react-native-test-app
FIXME: need to ask how to customise the AppDelegate as in the previous commit, as it's complaining about: Thread 1: "<ReactTestApp.AppDelegate: 0x10a3e7b50> does not conform to RNAppAuthAuthorizationFlowManager" And will likely need to do similar customisation for Android.
Configuration menu - View commit details
-
Copy full SHA for 3848cdd - Browse repository at this point
Copy the full SHA 3848cddView commit details -
fix(ios,macos): amend platform ifdefs
Based on these: facebook/react-native#42278
Configuration menu - View commit details
-
Copy full SHA for d5b8c28 - Browse repository at this point
Copy the full SHA d5b8c28View commit details -
Revert "feat: migrate to react-native-test-app"
This reverts commit ce193fc.
Configuration menu - View commit details
-
Copy full SHA for c41d1ed - Browse repository at this point
Copy the full SHA c41d1edView commit details -
Configuration menu - View commit details
-
Copy full SHA for d4ba607 - Browse repository at this point
Copy the full SHA d4ba607View commit details -
Configuration menu - View commit details
-
Copy full SHA for bbbae81 - Browse repository at this point
Copy the full SHA bbbae81View commit details -
Configuration menu - View commit details
-
Copy full SHA for fb4b005 - Browse repository at this point
Copy the full SHA fb4b005View commit details -
Configuration menu - View commit details
-
Copy full SHA for d7f3c41 - Browse repository at this point
Copy the full SHA d7f3c41View commit details -
Configuration menu - View commit details
-
Copy full SHA for a9ddf95 - Browse repository at this point
Copy the full SHA a9ddf95View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1dd0b44 - Browse repository at this point
Copy the full SHA 1dd0b44View commit details -
Configuration menu - View commit details
-
Copy full SHA for 85b1e5d - Browse repository at this point
Copy the full SHA 85b1e5dView commit details -
Configuration menu - View commit details
-
Copy full SHA for b3da68b - Browse repository at this point
Copy the full SHA b3da68bView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.