Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update versions, changelog #307

Merged
merged 4 commits into from
Oct 10, 2024
Merged

Conversation

vahancouver
Copy link
Contributor

SDKS-3362 [iOS] Release activities for SDK 4.6

  • Update podspec versions
  • Update marketing versions
  • Update sdkVersion in Log.swift
  • Update Changelog
  • Update PingOneSignals version from 5.2.3 to 5.2.7

Copy link
Contributor

@spetrov spetrov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!
Just minor comments that you may want to consider...

CHANGELOG.md Outdated
- Support PingOne Protect Marketplace Nodes [SDKS-3296]
- Make PolicyAdviceCreator public [SDKS-3349]
- Support new ReCaptcha Enterprise node [SDKS-3324]
- Expose realm, Success and Failure URL in GetSessionToken [SDKS-3352]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should that be SessionToken or simply Token instead of GetSessionToken? I guess it can stay like this though...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

CHANGELOG.md Outdated
@@ -1,3 +1,15 @@
## [4.6.0]
#### Added
- Skip Type 4 TextOutputCallback [SDKS-3226]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we better move this to the "Fixed" section?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

CHANGELOG.md Outdated
#### Added
- Skip Type 4 TextOutputCallback [SDKS-3226]
- Support PingOne Protect Marketplace Nodes [SDKS-3296]
- Make PolicyAdviceCreator public [SDKS-3349]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Move to "Fixed"?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

Copy link
Contributor

@rodrigoareis rodrigoareis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vahancouver vahancouver merged commit e4ec365 into develop Oct 10, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants