-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update versions, changelog #307
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
Just minor comments that you may want to consider...
CHANGELOG.md
Outdated
- Support PingOne Protect Marketplace Nodes [SDKS-3296] | ||
- Make PolicyAdviceCreator public [SDKS-3349] | ||
- Support new ReCaptcha Enterprise node [SDKS-3324] | ||
- Expose realm, Success and Failure URL in GetSessionToken [SDKS-3352] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should that be SessionToken
or simply Token
instead of GetSessionToken
? I guess it can stay like this though...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
CHANGELOG.md
Outdated
@@ -1,3 +1,15 @@ | |||
## [4.6.0] | |||
#### Added | |||
- Skip Type 4 TextOutputCallback [SDKS-3226] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we better move this to the "Fixed" section?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
CHANGELOG.md
Outdated
#### Added | ||
- Skip Type 4 TextOutputCallback [SDKS-3226] | ||
- Support PingOne Protect Marketplace Nodes [SDKS-3296] | ||
- Make PolicyAdviceCreator public [SDKS-3349] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Move to "Fixed"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
SDKS-3362 [iOS] Release activities for SDK 4.6