Test cases for API #61
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Most of the tests pass. Some pass only occasionally (!?). Jasmine does all of the tests (accessed via opening SpecRunner.html in a browser).
It's just one little test that uses random data and the hexToRgb helper.
While random data did seem like a good idea, unless you're using a quicktest equivalent it just makes your test ugly. All tests from now on will be by example. Lesson learned. (To see the lesson, go back.)
Please.*_to_* all tested now.
All tests are done! Most of them pass.
Now the specs are checked for code quality.
Each expect should test both its conditions, not just one. Both upper and lower bound are needed.
To make tests more complete, and to catch issue Fooidge#57.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've added Jasmine which hopefully do their job pretty well. Some of the tests do fail though, where Please gives me unexpected results. I've marked those tests as 'possibly found a bug' or similar.
See issue #19 for why.