-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tweak dialog chatboxes #203
Open
SimpleBrian
wants to merge
20
commits into
Foohy:master
Choose a base branch
from
SimpleBrian:ui-changes
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
still need to figure out how to reposition icon when dialog box flips over to the player's side.
cat icon breaks when gmod is run in 4:3 aspect ratio, but everything works otherwise.
branch 1 onwards is untouched.
this is not permanent and there are the original chatboxes to replace with later
thanks RDBomber for setting the foundation. wrote slightly cleaner code but commented out a check for resolutions lower than 720p because it broke everything for some reason. the 720p or lower check outputs a LUA error whereas removing it no longer outputs an error and idfk why, it *looks* like it shouldn't break anything, but it does, and that's why i commented it out. Co-Authored-By: RDBomber (OtherElement) <[email protected]>
merging new commits made from the source of the fork
merge new commits from master fork
merge fresh commits from master fork
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
not exactly a overhaul, just a bunch of tweaks here and there to improve the appearance of the chatboxes.
before:
after:
before:
after:
in-game video example:
some dialogs may overflow the chatbox, as well as covering the continue icon in the process, but it hopefully shouldn't be too much of an issue.