Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tweak dialog chatboxes #203

Open
wants to merge 20 commits into
base: master
Choose a base branch
from
Open

Conversation

SimpleBrian
Copy link

not exactly a overhaul, just a bunch of tweaks here and there to improve the appearance of the chatboxes.

  • tweaked chatbox designs.

before:

before (npc dialog)
before (narrate dialog)

after:

after (npc dialog)
after (narrate dialog)

  • added check on whether the player is speaking, and to use the player's chatbox.
  • this also means i had to adjust the code so that it no longer flips the chatbox horizontally.
  • AND tweaked the speaker's name's position to align correctly with the new element.

player dialog

  • added and changed dialog text from arial to anke.
  • slightly tweaked text dialog's position.
  • hacky code to replace "Click to continue..." with a minimalistic continue icon (should scale with monitor resolution AND aspect ratio).

before:

before tweaks

after:

after tweaks

in-game video example:

jazz_bar_intro

some dialogs may overflow the chatbox, as well as covering the continue icon in the process, but it hopefully shouldn't be too much of an issue.

SimpleBrian and others added 17 commits September 2, 2023 00:35
still need to figure out how to reposition icon when dialog box flips over to the player's side.
cat icon breaks when gmod is run in 4:3 aspect ratio, but everything works otherwise.
branch 1 onwards is untouched.
this is not permanent and there are the original chatboxes to replace with later
thanks RDBomber for setting the foundation. wrote slightly cleaner code but commented out a check for resolutions lower than 720p because it broke everything for some reason.

the 720p or lower check outputs a LUA error whereas removing it no longer outputs an error and idfk why, it *looks* like it shouldn't break anything, but it does, and that's why i commented it out.

Co-Authored-By: RDBomber (OtherElement) <[email protected]>
FINALLY FIXED ASPECT RATIO SCALING FOR THE CAT ICON.
@SimpleBrian SimpleBrian changed the title give dialog chatboxes a makeover tweak dialog chatboxes Sep 8, 2023
merging new commits made from the source of the fork
merge new commits from master fork
merge fresh commits from master fork
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant