Fix tagName to use args

Foodee · Jul 17, 2020 · e5344eb · e5344eb
1 parent 652e064
commit e5344eb
Show file tree

Hide file tree

Showing 4 changed files with 36 additions and 6 deletions.
diff --git a/addon/components/field-for.hbs b/addon/components/field-for.hbs
@@ -1,6 +1,6 @@
-{{#let (-element (or @tagName "div")) as |Tag|}}
+{{#let (-element this.tagName) as |Tag|}}
   <Tag
-    @tagName={{or @tagName "div"}}
+    @tagName={{this.tagName}}
     class={{
       concat
       "field-for "

diff --git a/addon/components/field-for.js b/addon/components/field-for.js
@@ -329,6 +329,16 @@ export default class FieldForComponent extends Component {
   @arg()
   form = null;
 
+  /**
+   * The tag name that we use for this field
+   * @property tagName
+   * @type String
+   * @default form
+   * @public
+   */
+  @arg(string)
+  tagName = 'div';
+
   /**
    * The label for this field
    * @property field

diff --git a/addon/components/form-for.hbs b/addon/components/form-for.hbs
@@ -1,6 +1,6 @@
-{{#let (-element (or @tagName "form")) as |Tag|}}
+{{#let (-element this.tagName) as |Tag|}}
   <Tag
-    @tagName={{or @tagName "form"}}
+    @tagName={{this.tagName}}
     class="
     form-for
     {{if this.formClasses this.formClasses}}
@@ -17,7 +17,7 @@
         field=(component
           "field-for"
           form=this
-          tagName=@fieldTagName
+          tagName=this.fieldTagName
           disabled=this.disabled
           readonly=this.readonly
           inlineEditing=this.inlineEditing
@@ -31,7 +31,7 @@
         fieldFor=(component
           "field-for"
           form=this
-          tagName=@fieldTagName
+          tagName=this.fieldTagName
           disabled=this.disabled
           readonly=this.readonly
           inlineEditing=this.inlineEditing

diff --git a/addon/components/form-for.js b/addon/components/form-for.js
@@ -173,6 +173,26 @@ export default class FormForComponent extends Component {
   @arg(object)
   model = {};
 
+  /**
+   * The tag name that we use for this form
+   * @property tagName
+   * @type String
+   * @default form
+   * @public
+   */
+  @arg(string)
+  tagName = 'form';
+
+  /**
+   * The tag name that we use for this form's fields
+   * @property fieldTagName
+   * @type String
+   * @default form
+   * @public
+   */
+  @arg(string)
+  fieldTagName = 'div';
+
   /**
    * Whether or not this form is disabled
    * @property disabled