Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add getComboxBoxItems method to DefaultCommandHandler and app-connection.ts #264

Open
wants to merge 12 commits into
base: main
Choose a base branch
from

Conversation

source-streamer
Copy link
Contributor

Describe what your code does

This adds a method to get all the text values for the items in a ComboBox, as an array in order if indeces of the items.

Is this pull request to fix a bug?

n/a

Is this pull request to extend the functionality of the codebase?

This extends the methods on the ComboBox to allow for easily getting all items in the combo box. This can serve the purpose of multiple testaces:

  • Validate quickly that all required items are present and in the correct order
  • When the contents of a ComboBox are dynamic, and you need to set a specific item as selection, this allows you to easily find the index of a specific item (e.g. with different test machines using different audio devices, this would allow finding the same virtual audio device by name on each machine).

Is the code tested?

Yes, the code is tested using the example app and the example test specs.

By submitting a pull request to this repository you are agreeing to assign the copyright on your submitted code to Focusrite Audio Engineering Ltd. Please check the box below to show you accept these terms.

  • I agree to assign copyright of any code accepted via this pull request process to Focusrite Audio engineering Ltd.

@source-streamer source-streamer requested a review from a team as a code owner December 11, 2024 11:12
Copy link
Collaborator

@ImJimmi ImJimmi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a great addition, thanks!

If you could address my suggestion about not failing if there are no items, I'd be happy to approve and get this merged!

source/cpp/source/DefaultCommandHandler.cpp Outdated Show resolved Hide resolved
@hiddekramermusic
Copy link

@ImJimmi just in case you missed the updates, your suggestions have now been added.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants