-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add getComboxBoxItems method to DefaultCommandHandler and app-connection.ts #264
Open
source-streamer
wants to merge
12
commits into
FocusriteGroup:main
Choose a base branch
from
source-streamer:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e ComboBox Component
determining the index of specific items in test-suites.
…bo-box-items-method-to-e-2-e-focusrite-framework Sc4 2350 e 2 e add get combo box items method to e 2 e focusrite framework
ImJimmi
reviewed
Dec 11, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a great addition, thanks!
If you could address my suggestion about not failing if there are no items, I'd be happy to approve and get this merged!
…_control_the_combobox_component Add possibility to control (get/set selected, get number of items) th…
Commit based on PR review suggestion. Co-authored-by: James J <[email protected]>
@ImJimmi just in case you missed the updates, your suggestions have now been added. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe what your code does
This adds a method to get all the text values for the items in a ComboBox, as an array in order if indeces of the items.
Is this pull request to fix a bug?
n/a
Is this pull request to extend the functionality of the codebase?
This extends the methods on the ComboBox to allow for easily getting all items in the combo box. This can serve the purpose of multiple testaces:
Is the code tested?
Yes, the code is tested using the example app and the example test specs.
By submitting a pull request to this repository you are agreeing to assign the copyright on your submitted code to Focusrite Audio Engineering Ltd. Please check the box below to show you accept these terms.