-
Notifications
You must be signed in to change notification settings - Fork 1
Pull Requests
Dinith edited this page May 24, 2020
·
3 revisions
All code that was pushed into the master
branch had to go through a Pull Request (PR). This ensured the integrity and correctness of the project.
Thorough code-review was carried out by all three of us for the PRs. This not only functioned to check the code's correctness, but also allowed everyone to learn of new changes and understand the different parts of the system better, ultimately making the overall development much easier.
PRs had to have at least one approval from a reviewer, and also had to the successfully build and pass the tests of the Continuous Integration module. This again ensure the integrity of the master
branch.