Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Webpack to rollupjs #19

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
53 changes: 51 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

Given a event data, drawn a beautiful timeline on canvas. Powered by short-night engine.

Try it in online:
Try it online:

- http://short-night.pea3nut.org/example/rule-example-1

Expand Down Expand Up @@ -73,7 +73,7 @@ const events = [{
Rules.draw('#app', events);
```

## Install
# Install

### In Webpack

Expand Down Expand Up @@ -169,3 +169,52 @@ The Short-Night engine. see:

- https://foxzilla.github.io/short-night/globals.html
- https://github.com/FoXZilla/short-night/blob/master/src/index.ts

# Contributor's Guide
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The steps you wrote is just basic knowledge on Github. We should move focus on how to run this Repo on your PC. E.g. Run npm run dev then open docs/webpack.html


Pull requests are welcome. For major changes, please open an issue first to discuss what you would like to change.

Please make sure to update tests as appropriate.

1. Fork the project on GitHub.

2. Clone the project.

3. perform the below command
```sh
npm link
ganganiSoN marked this conversation as resolved.
Show resolved Hide resolved
```
4. Create a branch specific to the issue you are working on.
```sh
git checkout -b branch-name
```
5. Add your modified files to Git,
```sh
git add path/to/filename.ext
```
You can also add all unstaged files using:
```sh
git add .
```
Note: using a git add . will automatically add all files. You can do a git status to see your changes, but do it before git add.

6. Commit your changes using a descriptive commit message.
```sh
git commit -m "Brief Description of Commit"
```
7. Push your commits to your GitHub Fork:
```sh
git push -u origin branch-name
```
8. Submit a pull request.

### Follow the below step in your local project

1. Installing the Rules
```sh
npm install @foxzilla/rules
```
2. Linking the Rules with your local connection
```sh
npm link @foxzilla/rules
```
543 changes: 516 additions & 27 deletions docs/rules.js

Large diffs are not rendered by default.

93 changes: 67 additions & 26 deletions docs/webpack-example.js

Large diffs are not rendered by default.

1 change: 0 additions & 1 deletion global-types.d.ts

This file was deleted.

Loading