Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Solve the problem that selectRoute cannot recover after finding a wildcard route during the initial attempt. #977

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

haodong404
Copy link

@haodong404 haodong404 commented Nov 12, 2024

Description

There are routes: /**, /test/, and if I want to find /test/ using Modular.to.pushNamed('/test'), /** will be matched, that is unexpected. So in this PR, when finding wildcard route at the first time in the selectRoute, it will also do the recovery.

Checklist

  • The title of my PR starts with a Conventional Commit prefix (fix:, feat:, docs: etc).
  • I have read the Contributor Guide and followed the process outlined for submitting PRs.
  • I have updated/added tests for ALL new/updated/fixed functionality.
  • I have updated/added relevant documentation in docs and added dartdoc comments with ///.
  • I have updated/added relevant examples in examples.

Breaking Change

  • Yes, this is a breaking change.
  • No, this is not a breaking change.

Related Issues

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant