Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Implement authentication with twitter #94

Draft
wants to merge 2 commits into
base: development
Choose a base branch
from

Conversation

lkmandy
Copy link
Contributor

@lkmandy lkmandy commented Feb 23, 2023

Description

Implement user authentication with Twitter

Fixes #21

Type of Change

  • ✨ New feature (non-breaking change which adds functionality)
  • 🛠️ Bug fix (non-breaking change which fixes an issue)
  • ❌ Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 Code refactor
  • ✅ Build configuration change
  • 📝 Documentation
  • 🗑️ Chore

Pre-launch Checklist

@lkmandy lkmandy self-assigned this Feb 23, 2023
@fonkamloic
Copy link
Contributor

You ported changes from the Facebook feature here. Not recommended.

What you should have done.
1- When you are done with a feat branch.

  • git push to a branch.
    2- git checkout to develop on local
    3- git checkout -b new_feat (a branch from develop, not previous feat branch)
    4- commence work.

What you should do now.
1- git checkout to develop.
2 - git create new_branch from develop.
3- carry over changes from here to new_branch and create a new PR

Closing now...

@fonkamloic fonkamloic closed this Feb 23, 2023
@fonkamloic fonkamloic reopened this Feb 26, 2023
- Add configurations for facebook authentication on ios
- Add configurations for facebook authentication on android
- Include the facebook authentication package
- Implement the logic for enabling facebook authentication
- Attach the facebook authentication logic to the user interface
- Move the facebook module to the facebook feature directory
- Add twitter authentication configurations on android and ios
- Implement the overall twitter authentication logic
- Attach the twitter authentication logic to the user interface
@lkmandy lkmandy force-pushed the implement-authentication-with-twitter branch from 3a136e1 to f4c911e Compare February 28, 2023 02:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: Implement Twitter Authentication
2 participants