Initial implementation #1

mlopezFC · 2024-06-04T22:04:35Z

No description provided.

fix wrong initial styling caused by the use of style keyword

javier-godoy

See https://github.com/FlowingCode/AddonStarter24/issues/31#issuecomment-2126999803

pom.xml

README.md

paodb · 2024-06-05T12:00:05Z

ViewIT line 61 still shows "paper-input"

paodb · 2024-06-05T12:03:01Z

The add-on name replacement is missing in the issues templates. See https://github.com/FlowingCode/TechnicalDocs/blob/master/addons/checklist-0.md#issue_template

README.md

src/main/java/com/flowingcode/vaadin/addons/syntaxhighlighter/SHLanguage.java

src/main/java/com/flowingcode/vaadin/addons/syntaxhighlighter/SHLanguagePrism.java

src/main/java/com/flowingcode/vaadin/addons/syntaxhighlighter/SHStyle.java

src/main/java/com/flowingcode/vaadin/addons/syntaxhighlighter/SHStylePrism.java

src/test/java/com/flowingcode/vaadin/addons/syntaxhighlighter/SyntaxHighlighterDemoView.java

provide a no argument constructor and another one that receives language and content

explain difference with plain SyntaxhHighlighter and add documentation for no arg constructor

src/main/java/com/flowingcode/vaadin/addons/syntaxhighlighter/BaseSyntaxHighlighter.java

paodb · 2024-08-05T14:49:11Z

Also make sure to update License file taking in consideration https://github.com/FlowingCode/AddonStarter24/blob/master/LICENSE that was recently updated (remove first lines).

README.md

paodb · 2024-08-05T14:53:36Z

Also un readme, remove reference to vaadin directory repository https://github.com/FlowingCode/AddonStarter24/pull/39/files

Rename the wrapLines attribute so it uses the same name as its javascript counterpart

paodb

Tested it and it all looks good now.

src/main/java/com/flowingcode/vaadin/addons/syntaxhighlighter/SHLanguage.java

src/main/java/com/flowingcode/vaadin/addons/syntaxhighlighter/SHLanguagePrism.java

src/main/java/com/flowingcode/vaadin/addons/syntaxhighlighter/SHStyle.java

src/main/java/com/flowingcode/vaadin/addons/syntaxhighlighter/SHStylePrism.java

src/test/java/com/flowingcode/vaadin/addons/syntaxhighlighter/SyntaxHighlighterDemo.java

src/test/java/com/flowingcode/vaadin/addons/syntaxhighlighter/SyntaxHighlighterPrismDemo.java

mlopezFC added 14 commits May 22, 2024 15:19

feat: add initial implementation

51290a1

build: update to Vaadin 24.4.0.beta5

f6385b9

fix: use stylename as the state name

b070d2f

fix wrong initial styling caused by the use of style keyword

fix(demo): fix initial demo values

3d06b5d

fix: fix issue caused by null style initial value

7305e63

docs: update license headers

863cfbe

docs: update license header

ac113f0

build: fix addon name in scm section

8de2dd2

build: fix inception year

d8515e1

build: fix group id

c49c77b

docs: replace README default values with correct ones

9004001

docs: add javadocs

1719ec2

fix: use correct default style and content

042f5b6

test: add basic unit testing

c63e770

mlopezFC requested a review from paodb June 4, 2024 22:04

javier-godoy requested changes Jun 5, 2024

View reviewed changes

paodb reviewed Jun 5, 2024

View reviewed changes

pom.xml Outdated Show resolved Hide resolved

paodb reviewed Jun 5, 2024

View reviewed changes

README.md Outdated Show resolved Hide resolved

paodb reviewed Jun 5, 2024

View reviewed changes

README.md Outdated Show resolved Hide resolved

paodb reviewed Jun 5, 2024

View reviewed changes

README.md Outdated Show resolved Hide resolved