Skip to content

Commit

Permalink
refactor!: remove default value for startTime
Browse files Browse the repository at this point in the history
  • Loading branch information
javier-godoy authored and paodb committed Jul 11, 2024
1 parent 58b7aa5 commit fd489d0
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 14 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -41,24 +41,13 @@
public class SimpleTimer extends Component implements HasSize, HasStyle, Serializable {

private static final long serialVersionUID = 1L;
private static final int START_TIME_S = 60;
private static final String DISPLAY = "display";
private static final String INLINE = "inline";
private static final String CURRENT_TIME = "currentTime";

/** Creates a timer with a start time of 60 */
/** Creates a timer */
public SimpleTimer() {
this(START_TIME_S);
}

/**
* Creates a timer using the start time passed in the constructor
*
* @param startTime value in seconds for the start time
*/
public SimpleTimer(final Number startTime) {
getElement().getStyle().set(DISPLAY, INLINE);
setStartTime(startTime);
}

/**
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -41,11 +41,10 @@ Polymer({
properties: {
/**
* Start time for the timer in seconds
* @default 60
*/
startTime: {
type: Number,
value: 60
value: 0
},
/**
* End time for the timer in seconds
Expand Down

0 comments on commit fd489d0

Please sign in to comment.