Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix missing last row when exporting Excel file #86

Merged
merged 2 commits into from
Dec 21, 2023
Merged

Fix missing last row when exporting Excel file #86

merged 2 commits into from
Dec 21, 2023

Conversation

flang
Copy link
Contributor

@flang flang commented Dec 18, 2023

Close #85

@flang flang requested review from mlopezFC and paodb December 18, 2023 12:58
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@flang flang requested a review from javier-godoy December 21, 2023 17:02
paodb
paodb approved these changes Dec 21, 2023
View reviewed changes
Copy link
Member

@paodb paodb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@paodb paodb merged commit db6b066 into master Dec 21, 2023
3 checks passed
@paodb paodb deleted the issue-85 branch December 21, 2023 19:38
@javier-godoy javier-godoy mentioned this pull request Feb 23, 2024
Closed
@mlopezFC mlopezFC mentioned this pull request Feb 23, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paodb paodb paodb approved these changes

@mlopezFC mlopezFC Awaiting requested review from mlopezFC

@javier-godoy javier-godoy Awaiting requested review from javier-godoy

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Excel is not exporting the last row in 2.1.1
2 participants
@flang @paodb