Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: update API to allow setting properties to icons #119

Merged
merged 1 commit into from
Mar 14, 2024
Merged

feat: update API to allow setting properties to icons #119

merged 1 commit into from
Mar 14, 2024

Conversation

paodb
Copy link
Member

@paodb paodb commented Mar 11, 2024

Close #113

@paodb paodb requested review from javier-godoy and mlopezFC March 11, 2024 15:53
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
3 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

mlopezFC
mlopezFC approved these changes Mar 13, 2024
View reviewed changes
Copy link
Member

@mlopezFC mlopezFC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent work. I tested it and it is working fine. LGTM

@javier-godoy javier-godoy merged commit 5cdb14f into master Mar 14, 2024
5 checks passed
@javier-godoy javier-godoy deleted the issue-113 branch March 14, 2024 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mlopezFC mlopezFC mlopezFC approved these changes

@javier-godoy javier-godoy javier-godoy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Setting of anchorpoint for Markers
3 participants
@paodb @javier-godoy @mlopezFC