Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for shadow DOM styling #42

Merged
merged 1 commit into from
Apr 30, 2024
Merged

feat: add support for shadow DOM styling #42

merged 1 commit into from
Apr 30, 2024

Conversation

javier-godoy
Copy link
Member

Close #41

@javier-godoy javier-godoy requested review from mlopezFC and paodb April 22, 2024 19:42
@paodb
Copy link
Member

paodb commented Apr 30, 2024

I don't think the original file lt2-paper-slider,js should be renamed (is the original file from the source library).

Copy link

sonarcloud bot commented Apr 30, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@javier-godoy
Copy link
Member Author

@paodb I'm not sure how to name the web-components. (I think it's a breaking change either way)

Copy link
Member

@paodb paodb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@paodb paodb merged commit a0e3ac1 into master Apr 30, 2024
3 checks passed
@paodb paodb deleted the fix-41 branch April 30, 2024 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot edit slider dots styles because CSS @apply has been removed
2 participants