Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor to add paper-slider sources to component and add detach logic #40

Merged
merged 6 commits into from
Apr 16, 2024
Merged

Refactor to add paper-slider sources to component and add detach logic #40

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
96c61e2
build: update vaadin version to 14.11.8
paodb Apr 16, 2024
06ff972
refactor: add paper slider source to the component
paodb Apr 16, 2024
00bbdbb
fix: add missing detached logic to slider
paodb Apr 16, 2024
c5f03a1
fix: remove redundant call to updateSlides
paodb Apr 16, 2024
5056c64
chore: update license headers
paodb Apr 16, 2024
5277728
build(demo): update commons-demo version to 3.9.0
paodb Apr 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
<description>Integration of @xpertsea/paper-slider for Vaadin 14+</description>

<properties>
<vaadin.version>14.10.3</vaadin.version>
<vaadin.version>14.11.8</vaadin.version>
<maven.compiler.source>1.8</maven.compiler.source>
<maven.compiler.target>1.8</maven.compiler.target>
<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
Expand Down Expand Up @@ -120,7 +120,7 @@
<dependency>
<groupId>com.flowingcode.vaadin.addons.demo</groupId>
<artifactId>commons-demo</artifactId>
<version>3.5.0</version>
<version>3.9.0</version>
<scope>test</scope>
</dependency>
</dependencies>
Expand Down
9 changes: 3 additions & 6 deletions src/main/java/com/flowingcode/vaadin/addons/carousel/Carousel.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
* #%L
* Carousel Addon
* %%
* Copyright (C) 2018 - 2021 Flowing Code
* Copyright (C) 2018 - 2024 Flowing Code
* %%
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
Expand All @@ -26,7 +26,6 @@
import com.vaadin.flow.component.EventData;
import com.vaadin.flow.component.HasSize;
import com.vaadin.flow.component.Tag;
import com.vaadin.flow.component.dependency.HtmlImport;
import com.vaadin.flow.component.dependency.JsModule;
import com.vaadin.flow.component.dependency.NpmPackage;
import com.vaadin.flow.shared.Registration;
Expand All @@ -38,9 +37,8 @@
*/
@SuppressWarnings("serial")
@Tag("l2t-paper-slider")
@HtmlImport("bower_components/l2t-paper-slider/l2t-paper-slider.html")
@NpmPackage(value = "@xpertsea/paper-slider", version = "3.0.0")
@JsModule("@xpertsea/paper-slider/l2t-paper-slider.js")
@NpmPackage(value = "@polymer/iron-a11y-keys-behavior", version = "3.0.1")
@JsModule("./paper-slider/l2t-paper-slider.js")
public class Carousel extends Component implements HasSize {

private static final String HIDE_NAV = "hideNav";
Expand All @@ -54,7 +52,6 @@ public class Carousel extends Component implements HasSize {

public Carousel(Slide... paperSlides) {
setSlides(paperSlides);
updateSlides(paperSlides);
initProperties();
}

Expand Down
2 changes: 1 addition & 1 deletion src/main/java/com/flowingcode/vaadin/addons/carousel/Slide.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
* #%L
* Carousel Addon
* %%
* Copyright (C) 2018 - 2021 Flowing Code
* Copyright (C) 2018 - 2024 Flowing Code
* %%
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
Expand Down
Loading
Loading