Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(cce): fix docs issues. #994

Merged
merged 1 commit into from
Sep 18, 2023

Conversation

Zippo-Wang
Copy link
Contributor

@Zippo-Wang Zippo-Wang commented Sep 7, 2023

fix docs issues.

data_source_flexibleengine_cce_clusters
1、add attribute field
image
image

Copy link
Contributor

@chengxiangdong chengxiangdong Sep 11, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clusters.masters.availability_zone is missing

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Referencing Huawei Cloud, not processed temporarily

Copy link
Contributor

@chengxiangdong chengxiangdong Sep 11, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

scall_enable and extend_param are missing

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

scall_enable is deprecated
extend_param declared in schema only, but it is not used

docs/resources/cce_cluster_v3.md Outdated Show resolved Hide resolved
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The validity of the arguments needs to be tested.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unit test has but docs miss the field

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ditto

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this docs have no field which is new added

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ditto

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unit test has but docs miss the field

@Zippo-Wang Zippo-Wang force-pushed the fix_docs_CCE branch 2 times, most recently from edc4287 to b1aa225 Compare September 12, 2023 06:42
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clusters.highway_subnet_id does not exist in schema

docs/resources/cce_node_v3.md Outdated Show resolved Hide resolved
@Zippo-Wang Zippo-Wang force-pushed the fix_docs_CCE branch 2 times, most recently from 384b35b to f1a55ee Compare September 13, 2023 07:19
@chengxiangdong
Copy link
Contributor

/lgtm

@github-actions github-actions bot added the LGTM label Sep 15, 2023

* `id` - (Optional) The ID of container cluster.
* `name` - (Optional, String)The Name of the cluster resource.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* `name` - (Optional, String)The Name of the cluster resource.
* `name` - (Optional, String)The Name of the cluster resource.

@github-actions github-actions bot removed the LGTM label Sep 18, 2023
@ShiChangkuo ShiChangkuo merged commit 59a8326 into FlexibleEngineCloud:master Sep 18, 2023
3 checks passed
@Zippo-Wang Zippo-Wang deleted the fix_docs_CCE branch November 1, 2023 07:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants