Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(bms): fix docs issues. #992

Merged

Conversation

Zippo-Wang
Copy link
Contributor

@Zippo-Wang Zippo-Wang commented Sep 7, 2023

fix docs issues.

1、docs/resources/compute_bms_server_v2.md

add attribute tenant_id filed
image
image

2、docs/data-source/compute_bms_server_v2.md

add attribute tenant_id filed
image
image

@github-actions github-actions bot added size/M and removed size/S labels Sep 7, 2023
@Zippo-Wang Zippo-Wang force-pushed the fix_docs_Compute_BMS branch 2 times, most recently from 61a96aa to aea8b64 Compare September 8, 2023 06:26
docs/data-sources/compute_bms_nic_v2.md Outdated Show resolved Hide resolved
docs/data-sources/compute_bms_server_v2.md Outdated Show resolved Hide resolved
docs/resources/compute_bms_server_v2.md Outdated Show resolved Hide resolved
docs/resources/compute_bms_server_v2.md Outdated Show resolved Hide resolved
@chengxiangdong
Copy link
Contributor

/lgtm

@github-actions github-actions bot added the LGTM label Sep 15, 2023
Changing this creates a new bms server.

* `security_groups` - (Optional) An array of one or more security group names
* `security_groups` - (Optional, Set) An array of one or more security group names
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we use List for both TypeList and TypeSet

Suggested change
* `security_groups` - (Optional, Set) An array of one or more security group names
* `security_groups` - (Optional, List) An array of one or more security group names

@github-actions github-actions bot removed the LGTM label Sep 18, 2023
@ShiChangkuo ShiChangkuo merged commit 5d1c532 into FlexibleEngineCloud:master Sep 18, 2023
3 checks passed
@Zippo-Wang Zippo-Wang deleted the fix_docs_Compute_BMS branch November 1, 2023 07:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants