-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(bms): fix docs issues. #992
Merged
ShiChangkuo
merged 1 commit into
FlexibleEngineCloud:master
from
Zippo-Wang:fix_docs_Compute_BMS
Sep 18, 2023
Merged
docs(bms): fix docs issues. #992
ShiChangkuo
merged 1 commit into
FlexibleEngineCloud:master
from
Zippo-Wang:fix_docs_Compute_BMS
Sep 18, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zippo-Wang
force-pushed
the
fix_docs_Compute_BMS
branch
from
September 7, 2023 06:58
6f3f192
to
1095ba4
Compare
Zippo-Wang
force-pushed
the
fix_docs_Compute_BMS
branch
2 times, most recently
from
September 8, 2023 06:26
61a96aa
to
aea8b64
Compare
ShiChangkuo
reviewed
Sep 8, 2023
Zippo-Wang
force-pushed
the
fix_docs_Compute_BMS
branch
from
September 8, 2023 08:46
aea8b64
to
152e119
Compare
/lgtm |
ShiChangkuo
reviewed
Sep 18, 2023
Changing this creates a new bms server. | ||
|
||
* `security_groups` - (Optional) An array of one or more security group names | ||
* `security_groups` - (Optional, Set) An array of one or more security group names |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we use List
for both TypeList and TypeSet
Suggested change
* `security_groups` - (Optional, Set) An array of one or more security group names | |
* `security_groups` - (Optional, List) An array of one or more security group names |
Zippo-Wang
force-pushed
the
fix_docs_Compute_BMS
branch
from
September 18, 2023 11:07
152e119
to
a25309b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix docs issues.
1、docs/resources/compute_bms_server_v2.md
add attribute
tenant_id
filed2、docs/data-source/compute_bms_server_v2.md
add attribute
tenant_id
filed