Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(docs): change the resource ID of the datasource. #1108

Conversation

liwanting0517
Copy link
Contributor

What this PR does / why we need it:

Which issue this PR fixes:
(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)
fixes #xxx

Special notes for your reviewer:

Release note:


PR Checklist

  • [] Tests added/passed.
  • Documentation updated.
  • [] Schema updated.

Acceptance Steps Performed

make testacc TEST='./flexibleengine' TESTARGS='-run=TestAccSomethingV0_basic'
...
=== RUN   TestAccSomethingV0_basic
--- PASS: TestAccSomethingV0_basic (70.75s)
PASS
ok      github.com/FlexibleEngineCloud/terraform-provider-flexibleengine/flexibleengine       70.796s

@@ -20,6 +20,6 @@ There are no arguments available for this data source.

In addition to all arguments above, the following attributes are exported:

* `id` - The account ID.
* `id` - The data source ID of the account.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the data source is singular, the id is the ID of corresponding resource. so I think it's unnecessary to update the description. Please revert others and replace resource with data source will be fine.

Suggested change
* `id` - The data source ID of the account.
* `id` - The account ID.

@liwanting0517 liwanting0517 force-pushed the lwt_dev_data_source_md branch from 2a65900 to e43131e Compare January 29, 2024 01:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants