feat(SFS): Synchronized SFS resource, unit test and document. #1101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liwanting0517
changed the title
Zippo-Wang
reviewed
Jan 17, 2024
docs/resources/sfs_access_rule_v2.md
Outdated
Comment on lines
61
to
62
| * `region` - (Optional, String, ForceNew) Specifies the region in which to create the RDS instance resource. | ||
| If omitted, the provider-level region will be used. Changing this will create a new RDS instance resource. |
There was a problem hiding this comment.
There should not be ... RDS instance ..., reference Huaweicloud
Comment on lines
77
to
79
| data "flexibleengine_vpc_v1" "test" { | ||
| name = "tf-xxx" | ||
| } |
There was a problem hiding this comment.
There should be formated
data "flexibleengine_vpc_v1" "test" {
name = "tf-xxx"
}
Comment on lines
96
to
98
| data "flexibleengine_vpc_v1" "test" { | ||
| name = "tf-xxx" | ||
| } |
liwanting0517
force-pushed
the
lwt_dev_sfs_access_rule_v2
branch
from
b1531a3 to
f609b3e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Which issue this PR fixes:
(optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged)fixes #xxx
Special notes for your reviewer:
Release note:
PR Checklist
Acceptance Steps Performed