feat(Network ACL): Synchronized Network ACL resources, unit test and document. #1095
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liwanting0517
changed the title
Zippo-Wang
reviewed
Jan 17, 2024
docs/resources/network_acl.md
Outdated
| @@ -45,6 +45,9 @@ resource "flexibleengine_network_acl" "fw_acl" { | |||
|
|
|||
| The following arguments are supported: | |||
|
|
|||
| * `region` - (Optional, String, ForceNew) Specifies the region where the private NAT gateway is located. | |||
There was a problem hiding this comment.
There should be ... NAT acl ... rather NAT gateway, you can reference from Huaweicloud/network_acl.md
docs/resources/network_acl_rule.md
Outdated
| @@ -26,6 +26,9 @@ resource "flexibleengine_network_acl_rule" "rule_1" { | |||
|
|
|||
| The following arguments are supported: | |||
|
|
|||
| * `region` - (Optional, String, ForceNew) Specifies the region where the private NAT gateway is located. | |||
There was a problem hiding this comment.
ditto, reference from Huaweicloud/network_acl_rule.md
| resource "flexibleengine_network_acl_rule" "rule_1" { | ||
| name = "%s" | ||
| protocol = "udp" | ||
| action = "deny" |
There was a problem hiding this comment.
All of scripts in this Unit Test should be formated.
Comment on lines
199
to
204
| resource "flexibleengine_vpc_subnet_v1" "subnet_1" { | ||
| name = "%s_subnet_1" | ||
| cidr = "192.168.0.0/24" | ||
| gateway_ip = "192.168.0.1" | ||
| vpc_id = flexibleengine_vpc_v1.vpc_1.id | ||
| } |
There was a problem hiding this comment.
all of scripts in this Unit Test should be formated.
liwanting0517
force-pushed
the
lwt_dev_network_acl
branch
from
3997e0d to
ff22e11
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Which issue this PR fixes:
(optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged)fixes #xxx
Special notes for your reviewer:
Release note:
PR Checklist
Acceptance Steps Performed