feat(NAT): Synchronized NAT resource, unit test and document. #1091
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liwanting0517
force-pushed
the
lwt_dev_nat_snat_rule_v2
branch
from
45414b3 to
6db536a
Compare
liwanting0517
changed the title
liwanting0517
force-pushed
the
lwt_dev_nat_snat_rule_v2
branch
2 times, most recently
from
e19c768 to
d18b65c
Compare
Zippo-Wang
reviewed
Jan 17, 2024
docs/resources/nat_snat_rule_v2.md
Outdated
| --- | ||
|
|
||
| # flexibleengine_nat_snat_rule_v2 | ||
|
|
||
| Manages a V2 SNAT rule resource within FlexibleEngine. | ||
| Manages an SNAT rule resource of the **public** NAT within FlexibleEngine. |
There was a problem hiding this comment.
There seems to use ... a SNAT ...
Comment on lines
94
to
119
| resource "flexibleengine_compute_instance_v2" "test" { | ||
| name = "instance_1" | ||
| security_groups = ["default"] | ||
| image_id = data.flexibleengine_images_image.test.id | ||
| flavor_id = data.flexibleengine_compute_flavors_v2.test.flavors[0] | ||
| availability_zone = data.flexibleengine_availability_zones.test.names[0] | ||
| metadata = { | ||
| foo = "bar" | ||
| } | ||
| network { | ||
| uuid = flexibleengine_vpc_subnet_v1.test.id | ||
| } | ||
| tags = { | ||
| key1 = "value1" | ||
| key2 = "value.key" | ||
| } | ||
| } | ||
|
|
||
| resource "flexibleengine_nat_gateway_v2" "test" { | ||
| name = "%[2]s" | ||
| description = "test for terraform" | ||
| spec = "2" | ||
| vpc_id = flexibleengine_vpc_v1.test.id | ||
| subnet_id = flexibleengine_vpc_subnet_v1.test.id | ||
| } | ||
| `, testBaseComputeResources(name), name) |
There was a problem hiding this comment.
These scripts should be formated.
liwanting0517
force-pushed
the
lwt_dev_nat_snat_rule_v2
branch
from
d18b65c to
9235729
Compare
ShiChangkuo
reviewed
Jan 27, 2024
Comment on lines
-3
to
-4
| description: "" | ||
| page_title: "flexibleengine_nat_snat_rule_v2" |
There was a problem hiding this comment.
please keep it as is. page_title is used for other platforms.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Which issue this PR fixes:
(optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged)fixes #xxx
Special notes for your reviewer:
Release note:
PR Checklist
Acceptance Steps Performed