feat(ECS): Synchronized ECS resources, unit test and document. #1090
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zippo-Wang
reviewed
Jan 17, 2024
Comment on lines
48
to
49
| data "flexibleengine_vpc_subnet_v1" "mynet" { | ||
| name = "subnet-default" |
There was a problem hiding this comment.
flexibleengine seems have no default vpc and subnet, it's better to use resource
| * `region` - (Optional, String, ForceNew) The region in which to create the interface attachment. | ||
| If omitted, the `region` argument of the provider is used. Changing this creates a new attachment. | ||
| * `region` - (Optional, String, ForceNew) The region in which to create the network interface attache resource. If | ||
| omitted, the provider-level region will be used. Changing this creates a new network interface attache resource. | ||
|
|
||
| * `instance_id` - (Required, String, ForceNew) The ID of the Instance to attach the Port or Network to. |
There was a problem hiding this comment.
lack
Changing this creates a new network interface attache resource.check if other fields is ForceNew and if have Changing this... in this document.
Comment on lines
163
to
167
| data "flexibleengine_compute_flavors_v2" "test" { | ||
| availability_zone = data.flexibleengine_availability_zones.test.names[0] | ||
| performance_type = "normal" | ||
| cpu_core = 2 | ||
| memory_size = 4 | ||
| } |
There was a problem hiding this comment.
this scripts should be formated
Comment on lines
177
to
181
| resource "flexibleengine_compute_instance_v2" "test" { | ||
| name = "%[1]s" | ||
| image_id = data.flexibleengine_images_images.test.images[0].id | ||
| flavor_id = data.flexibleengine_compute_flavors_v2.test.flavors[0] | ||
| availability_zone = data.flexibleengine_availability_zones.test.names[0] |
There was a problem hiding this comment.
there should have only one space on the left of the equal symbol
dengyali0125
force-pushed
the
dev
branch
2 times, most recently
from
3feddb2 to
f7b2a05
Compare
|
/lgtm |
|
/lgtm cancel |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Which issue this PR fixes:
(optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged)fixes #xxx
Special notes for your reviewer:
Release note:
PR Checklist
Acceptance Steps Performed
flexibleengine_compute_interface_attach
=== RUN TestAccComputeInterfaceAttach_Basic
=== PAUSE TestAccComputeInterfaceAttach_Basic
=== CONT TestAccComputeInterfaceAttach_Basic
--- PASS: TestAccComputeInterfaceAttach_Basic (624.92s)
PASS