Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(VPC): add secgroup_rule_v2 data source #1068

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

alexissellier
Copy link

What this PR does / why we need it:
Add data source for secgroup_rule_v2

Which issue this PR fixes:
(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)
fixes #xxx

Special notes for your reviewer:

Release note:


PR Checklist

  • [*] Tests added/passed.
  • [*] Documentation updated.
  • [*] Schema updated.

Acceptance Steps Performed


make testacc TEST='./flexibleengine/' TESTARGS='-run TestAccFlexibleEngineNetworkingSecGroupRuleV2DataSource_basic'
=== RUN   TestAccFlexibleEngineNetworkingSecGroupRuleV2DataSource_basic
--- PASS: TestAccFlexibleEngineNetworkingSecGroupRuleV2DataSource_basic (38.66s)
PASS
ok  	github.com/FlexibleEngineCloud/terraform-provider-flexibleengine/flexibleengine	38.685s

@ShiChangkuo
Copy link
Collaborator

@alexissellier Thank you for the pull request.

it's very appreciate if we add a new data source with plural format, such as flexibleengine_compute_instances, which is more convenient for users.

@alexissellier
Copy link
Author

Hi @ShiChangkuo ,

Noted, I will add a flexibleengine_networking_secgroup_rules data source

@chengxiangdong
Copy link
Contributor

/retitle feat(VPC): add secgroup_rule_v2 data source

@github-actions github-actions bot changed the title add secgroup_rule_v2 data source feat(VPC): add secgroup_rule_v2 data source Nov 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants