feat(RDS): import RDS resource, unit test and document. #1058

Zippo-Wang · 2023-10-31T08:36:30Z

What this PR does / why we need it:
import RDSresource, unit test and document.

Which issue this PR fixes:
(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)
fixes #xxx

Special notes for your reviewer:

Release note:

PR Checklist

Tests added/passed.
Documentation updated.
Schema updated.

Acceptance Steps Performed

### resource_flexibleengine_rds_backup

=== RUN   TestAccBackup_mysql_basic
=== PAUSE TestAccBackup_mysql_basic
=== CONT  TestAccBackup_mysql_basic
--- PASS: TestAccBackup_mysql_basic (1185.01s)
PASS

coverage: 2.1% of statements in ../../../terraform-provider-flexibleengine/...


=== RUN   TestAccBackup_sqlserver_basic
=== PAUSE TestAccBackup_sqlserver_basic
=== CONT  TestAccBackup_sqlserver_basic
--- PASS: TestAccBackup_sqlserver_basic (1931.04s)
PASS

coverage: 1.9% of statements in ../../../terraform-provider-flexibleengine/...


=== RUN   TestAccBackup_pg_basic
=== PAUSE TestAccBackup_pg_basic
=== CONT  TestAccBackup_pg_basic
--- PASS: TestAccBackup_pg_basic (1034.23s)
PASS

coverage: 1.9% of statements in ../../../terraform-provider-flexibleengine/...

### data_source_flexibleengine_rds_backup

=== RUN   TestAccDatasourceBackup_basic
=== PAUSE TestAccDatasourceBackup_basic
=== CONT  TestAccDatasourceBackup_basic
--- PASS: TestAccDatasourceBackup_basic (1108.51s)
PASS

coverage: 1.9% of statements in ../../../terraform-provider-flexibleengine/...


=== RUN   TestAccDatasourceBackup_auto_basic
=== PAUSE TestAccDatasourceBackup_auto_basic
=== CONT  TestAccDatasourceBackup_auto_basic
--- PASS: TestAccDatasourceBackup_auto_basic (412.16s)
PASS

coverage: 1.9% of statements in ../../../terraform-provider-flexibleengine/...

=== RUN   TestAccDatasourceBackup_incremental_basic
=== PAUSE TestAccDatasourceBackup_incremental_basic
=== CONT  TestAccDatasourceBackup_incremental_basic
--- PASS: TestAccDatasourceBackup_incremental_basic (432.17s)
PASS

coverage: 1.7% of statements in ../../../terraform-provider-flexibleengine/...

### data_source_flexibleengine_engine_versions

=== RUN   TestAccRdsEngineVersionsV3DataSource_basic
=== PAUSE TestAccRdsEngineVersionsV3DataSource_basic
=== CONT  TestAccRdsEngineVersionsV3DataSource_basic
--- PASS: TestAccRdsEngineVersionsV3DataSource_basic (44.08s)
PASS

coverage: 1.7% of statements in ../../../terraform-provider-flexibleengine/...

=== RUN   TestAccRdsEngineVersionsV3DataSource_PostgreSQL_basic
=== PAUSE TestAccRdsEngineVersionsV3DataSource_PostgreSQL_basic
=== CONT  TestAccRdsEngineVersionsV3DataSource_PostgreSQL_basic
--- PASS: TestAccRdsEngineVersionsV3DataSource_PostgreSQL_basic (38.72s)
PASS
coverage: 1.7% of statements in ../../../terraform-provider-flexibleengine/...

=== RUN   TestAccRdsEngineVersionsV3DataSource_SQLServer_basic
=== PAUSE TestAccRdsEngineVersionsV3DataSource_SQLServer_basic
=== CONT  TestAccRdsEngineVersionsV3DataSource_SQLServer_basic
--- PASS: TestAccRdsEngineVersionsV3DataSource_SQLServer_basic (43.08s)
PASS

coverage: 1.7% of statements in ../../../terraform-provider-flexibleengine/...

### data_source_flexibleengine_storage_types

=== RUN   TestAccDatasourceStoragetype_basic
=== PAUSE TestAccDatasourceStoragetype_basic
=== CONT  TestAccDatasourceStoragetype_basic
--- PASS: TestAccDatasourceStoragetype_basic (41.38s)
PASS

coverage: 1.7% of statements in ../../../terraform-provider-flexibleengine/...

=== RUN   TestAccDatasourceStoragetype_PostgreSQL_basic
=== PAUSE TestAccDatasourceStoragetype_PostgreSQL_basic
=== CONT  TestAccDatasourceStoragetype_PostgreSQL_basic
--- PASS: TestAccDatasourceStoragetype_PostgreSQL_basic (35.54s)
PASS

coverage: 1.7% of statements in ../../../terraform-provider-flexibleengine/...

=== RUN   TestAccDatasourceStoragetype_SQLServer_basic
=== PAUSE TestAccDatasourceStoragetype_SQLServer_basic
=== CONT  TestAccDatasourceStoragetype_SQLServer_basic
--- PASS: TestAccDatasourceStoragetype_SQLServer_basic (36.72s)
PASS
coverage: 1.7% of statements in ../../../terraform-provider-flexibleengine/...

### data_source_flexibleengine_rds_instances
=== RUN   TestAccRdsInstanceDataSource_basic
=== PAUSE TestAccRdsInstanceDataSource_basic
=== CONT  TestAccRdsInstanceDataSource_basic
--- PASS: TestAccRdsInstanceDataSource_basic (1086.39s)
PASS

coverage: 1.9% of statements in ../../../terraform-provider-flexibleengine/...


=== RUN   TestAccRdsInstanceDataSource_ha_basic
=== PAUSE TestAccRdsInstanceDataSource_ha_basic
=== CONT  TestAccRdsInstanceDataSource_ha_basic
--- PASS: TestAccRdsInstanceDataSource_ha_basic (165.64s)
PASS

=== RUN   TestAccRdsInstanceDataSource_replica_basic
=== PAUSE TestAccRdsInstanceDataSource_replica_basic
=== CONT  TestAccRdsInstanceDataSource_replica_basic
--- PASS: TestAccRdsInstanceDataSource_replica_basic (294.93s)
PASS

=== RUN   TestAccRdsInstanceDataSource_enterprise_basic
=== PAUSE TestAccRdsInstanceDataSource_enterprise_basic
=== CONT  TestAccRdsInstanceDataSource_enterprise_basic
--- PASS: TestAccRdsInstanceDataSource_enterprise_basic (33.76s)
PASS

### resource_flexibleengine_rds_sql_audit
=== RUN   TestAccSQLAudit_basic
=== PAUSE TestAccSQLAudit_basic
=== CONT  TestAccSQLAudit_basic
--- PASS: TestAccSQLAudit_basic (1077.14s)
PASS

coverage: 1.9% of statements in ../../../terraform-provider-flexibleengine/...

### resource_flexibleengine_rds_cross_region_backup_strategy
=== RUN   TestAccBackupStrategy_basic
=== PAUSE TestAccBackupStrategy_basic
=== CONT  TestAccBackupStrategy_basic
--- PASS: TestAccBackupStrategy_basic (1027.76s)
PASS

coverage: 1.9% of statements in ../../../terraform-provider-flexibleengine/...

github-actions · 2023-10-31T08:36:53Z

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

github-actions · 2023-10-31T08:36:55Z

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

github-actions · 2023-10-31T08:36:59Z

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

github-actions · 2023-10-31T12:08:10Z

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

github-actions · 2023-10-31T12:12:29Z

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

github-actions · 2023-10-31T12:21:01Z

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

github-actions · 2023-10-31T12:21:50Z

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

docs/data-sources/rds_storage_types.md

Zhukun-Huawei · 2023-11-21T02:47:53Z

docs/resources/rds_backup.md

+
+* `databases` - (Optional, List, ForceNew) List of self-built Microsoft SQL Server databases that are partially
+  backed up. (Only Microsoft SQL Server supports partial backups). The [databases](#rds_databases) structure is
+  documented below. Changing this parameter will create a new resource.


Changing this parameter will create a new resource. Is it need to be wrapped?

It is not mandatory, the Changing ... new resource should be declared when the field is ForceNew. As for it's location, one way is added behind the field description. Another way is starting a new line.

Zhukun-Huawei · 2023-11-21T02:50:14Z

docs/resources/rds_cross_region_backup_strategy.md

+  If omitted, the provider-level region will be used. Changing this parameter will create a new resource.
+
+* `instance_id` - (Required, String, ForceNew) Specifies the ID of the RDS instance.
+


extra line？

Zhukun-Huawei · 2023-11-21T02:51:06Z

docs/resources/rds_cross_region_backup_strategy.md

+The following arguments are supported:
+
+* `region` - (Optional, String, ForceNew) Specifies the region in which to create the resource.
+  If omitted, the provider-level region will be used. Changing this parameter will create a new resource.


Changing this parameter will create a new resource，does this sentence need to be wrapped

github-actions · 2023-11-21T07:07:49Z

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

Zhukun-Huawei

/lgtm

github-actions · 2023-11-22T03:36:03Z

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

github-actions · 2023-11-22T03:39:37Z

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

github-actions · 2023-11-22T03:48:06Z

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

github-actions · 2023-11-22T03:52:07Z

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

github-actions · 2023-11-22T06:29:48Z

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

github-actions · 2023-11-22T08:37:05Z

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

docs/data-sources/rds_flavors_v3.md

github-actions · 2023-11-23T13:09:47Z

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

docs/resources/rds_instance_v3.md

github-actions · 2023-11-23T13:12:56Z

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

github-actions bot added bugfix documentation feature size/XL labels Oct 31, 2023

Zippo-Wang force-pushed the migrate_RDS branch from 84bb47f to 83db433 Compare October 31, 2023 12:07

Zippo-Wang changed the title ~~feat(RDS): import RDSresource, unit test and document.~~ feat(RDS): import RDS resource, unit test and document. Oct 31, 2023

Zippo-Wang force-pushed the migrate_RDS branch from 83db433 to 7372589 Compare October 31, 2023 12:20

github-actions bot removed the documentation label Oct 31, 2023

Zippo-Wang force-pushed the migrate_RDS branch from 7372589 to 2d28f8a Compare October 31, 2023 12:21

Zhukun-Huawei reviewed Nov 21, 2023

View reviewed changes

Zippo-Wang force-pushed the migrate_RDS branch from 2d28f8a to f4fd934 Compare November 21, 2023 07:07

Zhukun-Huawei reviewed Nov 21, 2023

View reviewed changes

github-actions bot added the documentation label Nov 22, 2023

Zippo-Wang force-pushed the migrate_RDS branch from d639ea2 to 0667ac4 Compare November 22, 2023 03:39

github-actions bot removed the documentation label Nov 22, 2023

Zippo-Wang force-pushed the migrate_RDS branch from 0667ac4 to 0b1a219 Compare November 22, 2023 03:47

Zippo-Wang force-pushed the migrate_RDS branch from 0b1a219 to 0268593 Compare November 22, 2023 03:51

Zippo-Wang force-pushed the migrate_RDS branch from 0268593 to b6d76df Compare November 22, 2023 06:29

fix(RDS): import RDS resource and add unit test and document.

6a5e3d0

Zippo-Wang force-pushed the migrate_RDS branch from b6d76df to 6a5e3d0 Compare November 22, 2023 08:36

ShiChangkuo reviewed Nov 23, 2023

View reviewed changes

docs/data-sources/rds_flavors_v3.md Outdated Show resolved Hide resolved

Update docs/data-sources/rds_flavors_v3.md

af874b6

ShiChangkuo reviewed Nov 23, 2023

View reviewed changes

docs/resources/rds_instance_v3.md Outdated Show resolved Hide resolved

Update docs/resources/rds_instance_v3.md

67cd19b

ShiChangkuo added the LGTM label Nov 23, 2023

ShiChangkuo merged commit 7c56153 into FlexibleEngineCloud:master Nov 23, 2023
6 checks passed

Zippo-Wang deleted the migrate_RDS branch November 24, 2023 01:12

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(RDS): import RDS resource, unit test and document. #1058

feat(RDS): import RDS resource, unit test and document. #1058

Zippo-Wang commented Oct 31, 2023 •

edited

Loading

github-actions bot commented Oct 31, 2023

github-actions bot commented Oct 31, 2023

github-actions bot commented Oct 31, 2023

github-actions bot commented Oct 31, 2023

github-actions bot commented Oct 31, 2023

github-actions bot commented Oct 31, 2023

github-actions bot commented Oct 31, 2023

Zhukun-Huawei Nov 21, 2023

Zippo-Wang Nov 21, 2023

Zhukun-Huawei Nov 21, 2023

Zippo-Wang Nov 21, 2023

Zhukun-Huawei Nov 21, 2023

Zippo-Wang Nov 21, 2023

github-actions bot commented Nov 21, 2023

Zhukun-Huawei left a comment

github-actions bot commented Nov 22, 2023

github-actions bot commented Nov 22, 2023

github-actions bot commented Nov 22, 2023

github-actions bot commented Nov 22, 2023

github-actions bot commented Nov 22, 2023

github-actions bot commented Nov 22, 2023

github-actions bot commented Nov 23, 2023

github-actions bot commented Nov 23, 2023

		If omitted, the provider-level region will be used. Changing this parameter will create a new resource.

		* `instance_id` - (Required, String, ForceNew) Specifies the ID of the RDS instance.

feat(RDS): import RDS resource, unit test and document. #1058

feat(RDS): import RDS resource, unit test and document. #1058

Conversation

Zippo-Wang commented Oct 31, 2023 • edited Loading

PR Checklist

Acceptance Steps Performed

github-actions bot commented Oct 31, 2023

github-actions bot commented Oct 31, 2023

github-actions bot commented Oct 31, 2023

github-actions bot commented Oct 31, 2023

github-actions bot commented Oct 31, 2023

github-actions bot commented Oct 31, 2023

github-actions bot commented Oct 31, 2023

Zhukun-Huawei Nov 21, 2023

Choose a reason for hiding this comment

Zippo-Wang Nov 21, 2023

Choose a reason for hiding this comment

Zhukun-Huawei Nov 21, 2023

Choose a reason for hiding this comment

Zippo-Wang Nov 21, 2023

Choose a reason for hiding this comment

Zhukun-Huawei Nov 21, 2023

Choose a reason for hiding this comment

Zippo-Wang Nov 21, 2023

Choose a reason for hiding this comment

github-actions bot commented Nov 21, 2023

Zhukun-Huawei left a comment

Choose a reason for hiding this comment

github-actions bot commented Nov 22, 2023

github-actions bot commented Nov 22, 2023

github-actions bot commented Nov 22, 2023

github-actions bot commented Nov 22, 2023

github-actions bot commented Nov 22, 2023

github-actions bot commented Nov 22, 2023

github-actions bot commented Nov 23, 2023

github-actions bot commented Nov 23, 2023

Zippo-Wang commented Oct 31, 2023 •

edited

Loading