feat(elb): import elb 10sp2 resource and add unit test and docs #1056
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zhukun-Huawei
force-pushed
the
elb_branch
branch
4 times, most recently
from
e4ee28c to
1f69688
Compare
|
/lgtm |
Zhukun-Huawei
force-pushed
the
elb_branch
branch
from
1f69688 to
190099d
Compare
Zhukun-Huawei
force-pushed
the
elb_branch
branch
2 times, most recently
from
54e8a7f to
12501e0
Compare
|
/lgtm |
docs/data-sources/lb_listeners.md
Outdated
| subcategory: "Elastic Load Balance (ELB)" | ||
| --- | ||
|
|
||
| # flexibleengine_lb_listeners |
There was a problem hiding this comment.
Suggested change
| # flexibleengine_lb_listeners | |
| # flexibleengine_lb_listeners_v2 |
There was a problem hiding this comment.
done, revised
docs/resources/elb_logtank.md
Outdated
| subcategory: "Dedicated Load Balance (Dedicated ELB)" | ||
| --- | ||
|
|
||
| # flexibleengine_elb_logtank |
There was a problem hiding this comment.
Suggested change
| # flexibleengine_elb_logtank | |
| # flexibleengine_lb_logtank_v3 |
There was a problem hiding this comment.
done, revised
docs/data-sources/lb_certificate.md
Outdated
| subcategory: "Elastic Load Balance (ELB)" | ||
| --- | ||
|
|
||
| # flexibleengine_lb_certificate |
There was a problem hiding this comment.
Suggested change
| # flexibleengine_lb_certificate | |
| # flexibleengine_lb_certificate_v2 |
There was a problem hiding this comment.
done, revised
Zhukun-Huawei
force-pushed
the
elb_branch
branch
from
12501e0 to
9da0436
Compare
Zhukun-Huawei
changed the title
Zhukun-Huawei
force-pushed
the
elb_branch
branch
3 times, most recently
from
628a94f to
bcfc0a1
Compare
|
/lgtm |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Zhukun-Huawei
force-pushed
the
elb_branch
branch
from
bcfc0a1 to
b5e9c3f
Compare
There was a problem hiding this comment.
Please change the file name to lb_certificates_v2.md
Zhukun-Huawei
force-pushed
the
elb_branch
branch
from
b5e9c3f to
90194fd
Compare
Zhukun-Huawei
force-pushed
the
elb_branch
branch
3 times, most recently
from
0622576 to
c2eeaf8
Compare
Zhukun-Huawei
force-pushed
the
elb_branch
branch
from
c2eeaf8 to
f0aefa4
Compare
Zippo-Wang
pushed a commit
to Zippo-Wang/terraform-provider-flexibleengine
that referenced
this pull request
Jan 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
add lb resources for flexibleengine, including lb_listeners_v2, lb_log_tank_v3 and lb_certificate_v2
Which issue this PR fixes:
(optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged)fixes #xxx
Special notes for your reviewer:
Release note:
PR Checklist
Acceptance Steps Performed