feat(apig_signature): import apig_signature resource, unit test and document. #1055

Zhukun-Huawei · 2023-10-26T08:18:22Z

What this PR does / why we need it:

Which issue this PR fixes:
(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)
fixes #xxx

Special notes for your reviewer:

Release note:

PR Checklist

Tests added/passed.
Documentation updated.
Schema updated.

Acceptance Steps Performed

make testacc TEST='./flexibleengine' TESTARGS='-run=TestAccSomethingV0_basic'
...
=== RUN   TestAccSomethingV0_basic
--- PASS: TestAccSomethingV0_basic (70.75s)
PASS
ok      github.com/FlexibleEngineCloud/terraform-provider-flexibleengine/flexibleengine       70.796s

Zippo-Wang · 2023-11-16T09:19:53Z

flexibleengine/acceptance/acceptance.go

@@ -21,6 +21,7 @@ var (
 	OS_ACCESS_KEY             = os.Getenv("OS_ACCESS_KEY")
 	OS_SECRET_KEY             = os.Getenv("OS_SECRET_KEY")
 	OS_PROJECT_ID             = os.Getenv("OS_PROJECT_ID")
+	OS_USER_ID              = os.Getenv("OS_USER_ID")


use ctrl + alt + L to format the file

Zippo-Wang · 2023-11-16T09:21:53Z

flexibleengine/acceptance/common.go

@@ -55,7 +55,7 @@ data "flexibleengine_compute_flavors_v2" "test" {
  memory_size       = 4
 }

-data "flexibleengine_images_image" "test" {
+data "flexibleengine_images_image_v2" "test" {


flexibleengine_images_image_v2 is deprecated, use flexibleengine_images_image instead

done， revised

Zippo-Wang · 2023-11-16T09:24:54Z

docs/resources/apig_signature.md

+  + **hmac**: HMAC type.
+  + **aes**: AES type
+
+  Changing this will create a new resource.


This field is not ForceNew, please remove Changing this will create a new resource.

Zippo-Wang · 2023-11-16T09:25:10Z

docs/resources/apig_signature.md

+    It must start with a letter, digit, plus sign (+), or slash (/).
+
+  If not specified, the key will automatically generated. The auto-generation is only supported on first creation.  
+  Changing this will create a new resource.


This field is not ForceNew, please remove Changing this will create a new resource.

Zippo-Wang · 2023-11-16T09:25:37Z

docs/resources/apig_signature.md

+
+* `secret` - (Optional, String) Specifies the signature secret.  
+  If not specified, the secret will automatically generated. The auto-generation is only supported on first creation.  
+  Changing this will create a new resource.


This field is not ForceNew, please remove Changing this will create a new resource.

Zippo-Wang · 2023-11-16T09:26:01Z

docs/resources/apig_signature.md

+  + **aes-128-cfb**
+  + **aes-256-cfb**
+
+  Changing this will create a new resource.


This field is not ForceNew, please remove Changing this will create a new resource.

github-actions · 2023-11-20T08:06:41Z

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

github-actions · 2023-11-20T08:29:39Z

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

Zippo-Wang · 2023-11-21T01:34:52Z

/lgtm

chengxiangdong · 2023-11-21T11:51:06Z

/lgtm

Zippo-Wang · 2023-11-25T01:08:40Z

/lgtm

Zippo-Wang · 2023-11-25T03:33:25Z

/lgtm

chengxiangdong · 2023-11-25T08:21:33Z

/lgtm

chengxiangdong · 2023-11-27T12:35:57Z

/approve

…ocument.

github-actions bot added feature size/L labels Oct 26, 2023

Zippo-Wang reviewed Nov 16, 2023

View reviewed changes

github-actions bot added bugfix chore dependencies documentation size/XL and removed size/L labels Nov 20, 2023

Zhukun-Huawei force-pushed the unblocked_apig_branch branch from cd2732d to f02e8bb Compare November 20, 2023 08:29

Zhukun-Huawei force-pushed the unblocked_apig_branch branch from f02e8bb to 43f2401 Compare November 20, 2023 09:17

github-actions bot added size/L and removed documentation bugfix dependencies chore size/XL labels Nov 20, 2023

Zhukun-Huawei force-pushed the unblocked_apig_branch branch from 43f2401 to d584b1a Compare November 20, 2023 13:10

github-actions bot added the LGTM label Nov 21, 2023

Zhukun-Huawei force-pushed the unblocked_apig_branch branch from d584b1a to e3ff212 Compare November 24, 2023 03:33

github-actions bot removed the LGTM label Nov 24, 2023

Zhukun-Huawei force-pushed the unblocked_apig_branch branch 3 times, most recently from e058574 to ac8d84c Compare November 24, 2023 10:11

github-actions bot added the LGTM label Nov 25, 2023

Zhukun-Huawei force-pushed the unblocked_apig_branch branch from ac8d84c to 65aca06 Compare November 25, 2023 02:48

github-actions bot removed the LGTM label Nov 25, 2023

github-actions bot added the LGTM label Nov 25, 2023

github-actions bot added the approved label Nov 27, 2023

github-actions bot approved these changes Nov 27, 2023

View reviewed changes

feat(apig_signature): import apig_signature resource, unit test and d…

17854f3

…ocument.

Zhukun-Huawei force-pushed the unblocked_apig_branch branch from 65aca06 to 17854f3 Compare December 25, 2023 07:09

github-actions bot added size/XS and removed LGTM size/L labels Dec 25, 2023

Zhukun-Huawei closed this Dec 25, 2023

Zhukun-Huawei deleted the unblocked_apig_branch branch December 25, 2023 07:26

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(apig_signature): import apig_signature resource, unit test and document. #1055

feat(apig_signature): import apig_signature resource, unit test and document. #1055

Zhukun-Huawei commented Oct 26, 2023 •

edited

Loading

Zippo-Wang Nov 16, 2023

Zhukun-Huawei Nov 20, 2023

Zippo-Wang Nov 16, 2023

Zhukun-Huawei Nov 20, 2023

Zippo-Wang Nov 16, 2023

Zhukun-Huawei Nov 20, 2023 •

edited

Loading

Zippo-Wang Nov 16, 2023

Zhukun-Huawei Nov 20, 2023

Zippo-Wang Nov 16, 2023

Zhukun-Huawei Nov 20, 2023

Zippo-Wang Nov 16, 2023

Zhukun-Huawei Nov 20, 2023

github-actions bot commented Nov 20, 2023

github-actions bot commented Nov 20, 2023

Zippo-Wang commented Nov 21, 2023

chengxiangdong commented Nov 21, 2023

Zippo-Wang commented Nov 25, 2023

Zippo-Wang commented Nov 25, 2023

chengxiangdong commented Nov 25, 2023

chengxiangdong commented Nov 27, 2023

feat(apig_signature): import apig_signature resource, unit test and document. #1055

feat(apig_signature): import apig_signature resource, unit test and document. #1055

Conversation

Zhukun-Huawei commented Oct 26, 2023 • edited Loading

PR Checklist

Acceptance Steps Performed

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Zhukun-Huawei Nov 20, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

github-actions bot commented Nov 20, 2023

github-actions bot commented Nov 20, 2023

Zippo-Wang commented Nov 21, 2023

chengxiangdong commented Nov 21, 2023

Zippo-Wang commented Nov 25, 2023

Zippo-Wang commented Nov 25, 2023

chengxiangdong commented Nov 25, 2023

chengxiangdong commented Nov 27, 2023

Zhukun-Huawei commented Oct 26, 2023 •

edited

Loading

Zhukun-Huawei Nov 20, 2023 •

edited

Loading