Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(CSS): import CSS resource, unit test and document. #1054

Merged
merged 1 commit into from
Dec 25, 2023

Conversation

Zippo-Wang
Copy link
Contributor

@Zippo-Wang Zippo-Wang commented Oct 26, 2023

What this PR does / why we need it:
import data_source_flexibleengine_css_flavors resource, unit test and document.

Which issue this PR fixes:
(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)
fixes #xxx

Special notes for your reviewer:

Release note:


PR Checklist

  • Tests added/passed.
  • Documentation updated.
  • Schema updated.

Acceptance Steps Performed

make testacc TEST='./flexibleengine' TESTARGS='-run=TestAccSomethingV0_basic'
...
=== RUN   TestAccCssFlavorsDataSource_basic
=== PAUSE TestAccCssFlavorsDataSource_basic
=== CONT  TestAccCssFlavorsDataSource_basic
--- PASS: TestAccCssFlavorsDataSource_basic (57.14s)
PASS
coverage: 1.7% of statements in ../../../terraform-provider-flexibleengine/...

=== RUN   TestAccCssFlavorsDataSource_all
=== PAUSE TestAccCssFlavorsDataSource_all
=== CONT  TestAccCssFlavorsDataSource_all
--- PASS: TestAccCssFlavorsDataSource_all (196.49s)
PASS

coverage: 1.7% of statements in ../../../terraform-provider-flexibleengine/...

@Zippo-Wang Zippo-Wang changed the title Migrate css feat(CSS): import CSS resource, unit test and document. Oct 26, 2023
@Zippo-Wang Zippo-Wang force-pushed the migrate_CSS branch 4 times, most recently from 7c0e288 to fe94090 Compare October 26, 2023 08:02
@Zippo-Wang Zippo-Wang force-pushed the migrate_CSS branch 2 times, most recently from 5752eb5 to fe94090 Compare November 3, 2023 07:04
@@ -286,6 +287,8 @@ func Provider() *schema.Provider {
"flexibleengine_cbr_backup": cbr.DataSourceBackup(),
"flexibleengine_cce_clusters": cce.DataSourceCCEClusters(),

"flexibleengine_css_flavors": css.DataSourceCssFlavors(),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should align with other rows

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is not mandatory.

Copy link
Contributor

@Zhukun-Huawei Zhukun-Huawei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@github-actions github-actions bot added the LGTM label Nov 21, 2023
@github-actions github-actions bot removed the LGTM label Nov 25, 2023
@Zippo-Wang Zippo-Wang force-pushed the migrate_CSS branch 2 times, most recently from a035fd8 to 0a3a90f Compare November 27, 2023 02:02
@chengxiangdong
Copy link
Contributor

/assign

@chengxiangdong
Copy link
Contributor

/unassign

@chengxiangdong
Copy link
Contributor

/lgtm cancel

@github-actions github-actions bot removed the LGTM label Nov 27, 2023
@chengxiangdong
Copy link
Contributor

/approve

github-actions[bot]
github-actions bot previously approved these changes Nov 27, 2023
@chengxiangdong
Copy link
Contributor

/lgtm

@github-actions github-actions bot added the LGTM label Nov 27, 2023
@chengxiangdong
Copy link
Contributor

/approve cancel

@github-actions github-actions bot dismissed their stale review November 27, 2023 06:29

Canceled through prow-github-actions by @chengxiangdong

@chengxiangdong
Copy link
Contributor

/lgtm cancel

@github-actions github-actions bot removed the LGTM label Nov 27, 2023
@chengxiangdong
Copy link
Contributor

/lgtm
/approve

@github-actions github-actions bot added the LGTM label Nov 27, 2023
@ShiChangkuo ShiChangkuo merged commit 77df0f2 into FlexibleEngineCloud:master Dec 25, 2023
6 checks passed
@Zippo-Wang Zippo-Wang deleted the migrate_CSS branch December 25, 2023 03:15
Zippo-Wang added a commit to Zippo-Wang/terraform-provider-flexibleengine that referenced this pull request Jan 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants