-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(apig): import api_gateway and apig (Dedicated api_gateway) resource… #1050
feat(apig): import api_gateway and apig (Dedicated api_gateway) resource… #1050
Conversation
8a9b20e
to
cbce878
Compare
454d41b
to
96136e5
Compare
96136e5
to
1474ca3
Compare
This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size. |
1 similar comment
This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size. |
1474ca3
to
44375c4
Compare
This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size. |
44375c4
to
8a25531
Compare
This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size. |
3 similar comments
This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size. |
This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size. |
This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size. |
8a25531
to
554e6a1
Compare
This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size. |
554e6a1
to
e2e6dc2
Compare
This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size. |
1 similar comment
This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size. |
c7a4b56
to
223e2c5
Compare
This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size. |
2 similar comments
This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size. |
This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size. |
223e2c5
to
0569ac1
Compare
0e0f2d4
to
3063061
Compare
This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size. |
done, i have rebased |
3063061
to
fe2c8ef
Compare
This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size. |
fe2c8ef
to
316130f
Compare
This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size. |
316130f
to
9e96a41
Compare
This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size. |
/lgtm |
docs/resources/apig_acl_policy.md
Outdated
variable "instance_id" {} | ||
variable "policy_name" {} | ||
variable "ip_addresses" { | ||
type = list(stirng) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
type = list(stirng) | |
type = list(string) |
docs/resources/apig_acl_policy.md
Outdated
variable "instance_id" {} | ||
variable "policy_name" {} | ||
variable "domain_names" { | ||
type = list(stirng) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ditto
|
||
# flexibleengine_apig_acl_policy_associate | ||
|
||
Use this resource to bind the APIs to the ACL policy within Flexibleengine. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use this resource to bind the APIs to the ACL policy within Flexibleengine. | |
Use this resource to bind the APIs to the ACL policy within FlexibleEngine. |
|
||
# flexibleengine_apig_application_authorization | ||
|
||
Using this resoruce to authorize APIs for application, allowing it to access the published APIs within Flexibleengine. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Using this resoruce to authorize APIs for application, allowing it to access the published APIs within Flexibleengine. | |
Using this resource to authorize APIs for application, allowing it to access the published APIs within FlexibleEngine. |
@@ -0,0 +1,47 @@ | |||
--- | |||
subcategory: "API Gateway (Shared APIG)" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
subcategory: "API Gateway (Shared APIG)" | |
subcategory: "API Gateway" |
/lgtm cancel |
9e96a41
to
9e25a2d
Compare
This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size. |
9e25a2d
to
4ec2363
Compare
This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size. |
/lgtm |
This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size. |
What this PR does / why we need it:
add resource api_gateway_environment resource for flexibleengine
Which issue this PR fixes:
(optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close that issue when PR gets merged)fixes #xxx
Special notes for your reviewer:
Release note:
PR Checklist
Schema updated.
Acceptance Steps Performed
注:
api-acl-policy 这个资源的API文档无domain_id这个枚举值,单测也跑不通所以在本pr中去掉了这个枚举