Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(apig): import api_gateway and apig (Dedicated api_gateway) resource… #1050

Merged
merged 2 commits into from
Dec 24, 2023

Conversation

Zhukun-Huawei
Copy link
Contributor

@Zhukun-Huawei Zhukun-Huawei commented Oct 17, 2023

What this PR does / why we need it:
add resource api_gateway_environment resource for flexibleengine
Which issue this PR fixes:
(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)
fixes #xxx

Special notes for your reviewer:

Release note:

PR Checklist

  • Tests added/passed.
  • Documentation updated.
    Schema updated.

Acceptance Steps Performed

api-gateway-environment
=== RUN   TestAccEnvironment_basic
=== PAUSE TestAccEnvironment_basic
=== CONT  TestAccEnvironment_basic
--- PASS: TestAccEnvironment_basic (162.50s)
PASS
coverage: 1.7% of statements in ../../../terraform-provider-flexibleengine/...
apig-acl-policy
=== RUN   TestAccAclPolicy_basic
=== PAUSE TestAccAclPolicy_basic
=== CONT  TestAccAclPolicy_basic
--- PASS: TestAccAclPolicy_basic (632.02s)
PASS
coverage: 2.1% of statements in ../../../terraform-provider-flexibleengine/...
apig-acl-policy-associate
=== RUN   TestAccAclPolicyAssociate_basic
=== PAUSE TestAccAclPolicyAssociate_basic
=== CONT  TestAccAclPolicyAssociate_basic
--- PASS: TestAccAclPolicyAssociate_basic (793.73s)
PASS
coverage: 3.8% of statements in ../../../terraform-provider-flexibleengine/...
apig-channel
=== RUN   TestAccChannel_basic
=== PAUSE TestAccChannel_basic
=== CONT  TestAccChannel_basic
--- PASS: TestAccChannel_basic (664.47s)
PASS
coverage: 4.0% of statements in ../../../terraform-provider-flexibleengine/...
apig-instance-routes
=== RUN   TestAccInstanceRoutes_basic
=== PAUSE TestAccInstanceRoutes_basic
=== CONT  TestAccInstanceRoutes_basic
--- PASS: TestAccInstanceRoutes_basic (544.33s)
PASS
coverage: 2.1% of statements in ../../../terraform-provider-flexibleengine/...

注:
image

api-acl-policy 这个资源的API文档无domain_id这个枚举值,单测也跑不通所以在本pr中去掉了这个枚举

@github-actions github-actions bot added size/L and removed size/M labels Oct 18, 2023
@Zhukun-Huawei Zhukun-Huawei changed the title feat(api_gateway_environment):import api_gateway_environment resource… feat(api_gateway_environment):import api_gateway and apig (Dedicated api_gateway) resource… Oct 18, 2023
@Zhukun-Huawei Zhukun-Huawei changed the title feat(api_gateway_environment):import api_gateway and apig (Dedicated api_gateway) resource… feat(apig):import api_gateway and apig (Dedicated api_gateway) resource… Oct 18, 2023
@github-actions github-actions bot added size/XL and removed size/L labels Oct 18, 2023
@github-actions
Copy link

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

1 similar comment
@github-actions
Copy link

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

@github-actions
Copy link

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

@github-actions
Copy link

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

3 similar comments
@github-actions
Copy link

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

@github-actions
Copy link

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

@github-actions
Copy link

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

@github-actions
Copy link

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

@github-actions
Copy link

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

1 similar comment
@github-actions
Copy link

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

@github-actions
Copy link

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

2 similar comments
@github-actions
Copy link

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

@github-actions
Copy link

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

Copy link

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

@Zhukun-Huawei
Copy link
Contributor Author

pls resolve the conflicts

done, i have rebased

Copy link

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

Copy link

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

Copy link

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

@Zippo-Wang
Copy link
Contributor

/lgtm

@github-actions github-actions bot added the LGTM label Nov 25, 2023
variable "instance_id" {}
variable "policy_name" {}
variable "ip_addresses" {
type = list(stirng)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
type = list(stirng)
type = list(string)

variable "instance_id" {}
variable "policy_name" {}
variable "domain_names" {
type = list(stirng)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ditto


# flexibleengine_apig_acl_policy_associate

Use this resource to bind the APIs to the ACL policy within Flexibleengine.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Use this resource to bind the APIs to the ACL policy within Flexibleengine.
Use this resource to bind the APIs to the ACL policy within FlexibleEngine.


# flexibleengine_apig_application_authorization

Using this resoruce to authorize APIs for application, allowing it to access the published APIs within Flexibleengine.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Using this resoruce to authorize APIs for application, allowing it to access the published APIs within Flexibleengine.
Using this resource to authorize APIs for application, allowing it to access the published APIs within FlexibleEngine.

@@ -0,0 +1,47 @@
---
subcategory: "API Gateway (Shared APIG)"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
subcategory: "API Gateway (Shared APIG)"
subcategory: "API Gateway"

@chengxiangdong
Copy link
Contributor

/lgtm cancel

Copy link

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

Copy link

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

@chengxiangdong
Copy link
Contributor

/lgtm
/approve

@github-actions github-actions bot added the LGTM label Nov 28, 2023
@github-actions github-actions bot removed the LGTM label Dec 24, 2023
Copy link

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

@ShiChangkuo ShiChangkuo merged commit 2b93f8b into FlexibleEngineCloud:master Dec 24, 2023
5 of 6 checks passed
Zippo-Wang pushed a commit to Zippo-Wang/terraform-provider-flexibleengine that referenced this pull request Dec 25, 2023
@Zhukun-Huawei Zhukun-Huawei deleted the apig_branch branch December 26, 2023 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants