Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(dms_flavors): import dms_flavors resource and add unit test and document #1048

Merged
merged 1 commit into from
Nov 21, 2023

Conversation

Zhukun-Huawei
Copy link
Contributor

No description provided.

@Zhukun-Huawei Zhukun-Huawei changed the title feat(dms_flavors): import dms_flavors resource and add unit test and document feat(dms_kafka_flavors): import dms_kafka_flavors resource and add unit test and document Oct 16, 2023
@Zhukun-Huawei Zhukun-Huawei changed the title feat(dms_kafka_flavors): import dms_kafka_flavors resource and add unit test and document feat(dms_flavors): import dms_flavors resource and add unit test and document Oct 16, 2023
@Zhukun-Huawei Zhukun-Huawei force-pushed the dms_branch branch 2 times, most recently from 154563b to 0d15cef Compare November 2, 2023 09:20
@github-actions github-actions bot added size/L and removed size/S labels Nov 2, 2023
@@ -294,8 +294,10 @@ func Provider() *schema.Provider {
"flexibleengine_ddm_accounts": ddm.DataSourceDdmAccounts(),

"flexibleengine_dms_kafka_instances": dms.DataSourceDmsKafkaInstances(),
"flexibleengine_dms_kafka_flavors": dms.DataSourceKafkaFlavors(),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you can use ctrl + alt + l to format this file


* `versions` - The supported flavor versions.

* `flavors` - The list of flavor details.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Usually, the field name, structure name and block name should keep consistent
there are some fields such as ios,support_features,properties have the same problem in this document

* `flavors` - The list of flavor details.
The [flavors](#dms_kafka_flavors) structure is documented below.

@Zippo-Wang
Copy link
Contributor

/lgtm

@github-actions github-actions bot added the LGTM label Nov 21, 2023
@ShiChangkuo ShiChangkuo merged commit 6922e0c into FlexibleEngineCloud:master Nov 21, 2023
6 checks passed
@Zhukun-Huawei Zhukun-Huawei deleted the dms_branch branch December 26, 2023 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants