feat(Elb): import Elb 10sp1 resource and add unit test and document #1045
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zhukun-Huawei
force-pushed
the
import_elb_branch
branch
from
5a474fc to
7cc2881
Compare
Zippo-Wang
reviewed
Nov 3, 2023
Comment on lines
60
to
64
| * `listeners` - The listener which the security policy associated with. | ||
| The [ListenerRef](#SecurityPoliciesV3_ListenerRef) structure is documented below. | ||
|
|
||
| <a name="SecurityPoliciesV3_ListenerRef"></a> | ||
| The `ListenerRef` block supports: |
There was a problem hiding this comment.
Usually, the field name, structure name and block name should keep consistent
* `listeners` - The listener which the security policy associated with.
The [listeners](#elb_listeners) structure is documented below.
<a name="elb_listeners"></a>
The `listeners` block supports:There was a problem hiding this comment.
done, i revise these three items to be consistent
Comment on lines
96
to
97
| "TLSv1.1", | ||
| "TLSv1.2" |
There was a problem hiding this comment.
advise to cover all dictionary values
There was a problem hiding this comment.
ok, i have revised
|
This branch have conflicts, you can solve the conflicts first and then solve the review problem. |
github-actions
bot
added
bugfix
chore
dependencies
documentation
size/XL
and removed
size/M
labels
|
This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size. |
Zhukun-Huawei
force-pushed
the
import_elb_branch
branch
from
658852c to
d249979
Compare
|
This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size. |
Zhukun-Huawei
force-pushed
the
import_elb_branch
branch
from
d249979 to
810812b
Compare
github-actions
bot
added
size/M
and removed
dependencies
chore
bugfix
documentation
size/XL
labels
Zhukun-Huawei
force-pushed
the
import_elb_branch
branch
2 times, most recently
from
6d6fbe2 to
8695416
Compare
|
/lgtm |
|
Please fix the doc-lint issues |
Zhukun-Huawei
force-pushed
the
import_elb_branch
branch
from
8695416 to
f9e77a7
Compare
Zhukun-Huawei
force-pushed
the
import_elb_branch
branch
2 times, most recently
from
5cbe0c1 to
29643fe
Compare
Zhukun-Huawei
force-pushed
the
import_elb_branch
branch
from
29643fe to
f5ef636
Compare
|
/lgtm |
| subcategory: "Dedicated Load Balance (Dedicated ELB)" | ||
| --- | ||
|
|
||
| # flexibleengine_elb_security_policy |
There was a problem hiding this comment.
Suggested change
| # flexibleengine_elb_security_policy | |
| # flexibleengine_lb_security_policy_v3 |
flexibleengine/provider.go
Outdated
| "flexibleengine_drs_job": drs.ResourceDrsJob(), | ||
| "flexibleengine_drs_job": drs.ResourceDrsJob(), | ||
|
|
||
| "flexibleengine_elb_security_policy": elb.ResourceSecurityPolicy(), |
There was a problem hiding this comment.
Suggested change
| "flexibleengine_elb_security_policy": elb.ResourceSecurityPolicy(), | |
| "flexibleengine_lb_security_policy_v3": elb.ResourceSecurityPolicy(), |
Zhukun-Huawei
force-pushed
the
import_elb_branch
branch
from
f5ef636 to
7d64fb0
Compare
Zhukun-Huawei
changed the title
Zhukun-Huawei
force-pushed
the
import_elb_branch
branch
2 times, most recently
from
e6f856d to
52df6be
Compare
Zhukun-Huawei
force-pushed
the
import_elb_branch
branch
from
52df6be to
22e44a7
Compare
|
/lgtm |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Zippo-Wang
pushed a commit
to Zippo-Wang/terraform-provider-flexibleengine
that referenced
this pull request
Jan 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.