Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(DDS): import DDS resource, unit test and document. #1039

Merged
merged 1 commit into from
Dec 25, 2023
Merged

feat(DDS): import DDS resource, unit test and document. #1039

merged 1 commit into from
Dec 25, 2023

Conversation

Zippo-Wang
Copy link
Contributor

@Zippo-Wang Zippo-Wang commented Oct 12, 2023 •
edited
Loading

What this PR does / why we need it:
import resource_flexibleengine_dds_parameter_template, flexibleengine_dds_audit_log_policy, flexibleengine_dds_backup, flexibleengine_dds_instances resource, unit test and document

Which issue this PR fixes:
(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)
fixes #xxx

Special notes for your reviewer:

Release note:

PR Checklist

  • Tests added/passed.
  • Documentation updated.
  • Schema updated.

Acceptance Steps Performed

### resource_flexibleengine_dds_parameter_template

=== RUN   TestAccDdsParameterTemplate_basic
=== PAUSE TestAccDdsParameterTemplate_basic
=== CONT  TestAccDdsParameterTemplate_basic
--- PASS: TestAccDdsParameterTemplate_basic (98.42s)
PASS
coverage: 1.7% of statements in ../../../terraform-provider-flexibleengine/...

=== RUN   TestAccDdsParameterTemplate_shared_basic
=== PAUSE TestAccDdsParameterTemplate_shared_basic
=== CONT  TestAccDdsParameterTemplate_shared_basic
--- PASS: TestAccDdsParameterTemplate_shared_basic (41.51s)
PASS

coverage: 1.7% of statements in ../../../terraform-provider-flexibleengine/...

=== RUN   TestAccDdsParameterTemplate_config_basic
=== PAUSE TestAccDdsParameterTemplate_config_basic
=== CONT  TestAccDdsParameterTemplate_config_basic
--- PASS: TestAccDdsParameterTemplate_config_basic(42.15s)
PASS
coverage: 1.7% of statements in ../../../terraform-provider-flexibleengine/...

=== RUN   TestAccDdsParameterTemplate_replica_basic
=== PAUSE TestAccDdsParameterTemplate_replica_basic
=== CONT  TestAccDdsParameterTemplate_replica_basic
--- PASS: TestAccDdsParameterTemplate_replica_basic(39.18s)
PASS
coverage: 1.7% of statements in ../../../terraform-provider-flexibleengine/...

=== RUN   TestAccDdsParameterTemplate_single_basic
=== PAUSE TestAccDdsParameterTemplate_single_basic
=== CONT  TestAccDdsParameterTemplate_single_basic
--- PASS: TestAccDdsParameterTemplate_single_basic(44.33s)
PASS
coverage: 1.7% of statements in ../../../terraform-provider-flexibleengine/...

### resource_flexibleengine_dds_instances

=== RUN   TestAccDatasourceDdsInstance_basic
=== PAUSE TestAccDatasourceDdsInstance_basic
=== CONT  TestAccDatasourceDdsInstance_basic
--- PASS: TestAccDatasourceDdsInstance_basic (665.09s)
PASS

coverage: 2.7% of statements in ../../../terraform-provider-flexibleengine/...

### resource_flexibleengine_dds_audit_log_policy

=== RUN   TestAccDdsAuditLogPolicy_basic
=== PAUSE TestAccDdsAuditLogPolicy_basic
=== CONT  TestAccDdsAuditLogPolicy_basic
--- PASS: TestAccDdsAuditLogPolicy_basic (636.70s)
PASS

### resource_flexibleengine_dds_backup

=== RUN   TestAccDdsBackup_basic
=== PAUSE TestAccDdsBackup_basic
=== CONT  TestAccDdsBackup_basic
--- PASS: TestAccDdsBackup_basic (869.80s)
PASS

@Zippo-Wang Zippo-Wang force-pushed the migrate_DDS-parameter_template branch from a39d3f1 to 4545bb5 Compare October 19, 2023 02:25
@chengxiangdong
Copy link
Contributor

Wait for other resources or data sources belonging to the service to be migrated before merging.

@Zippo-Wang Zippo-Wang force-pushed the migrate_DDS-parameter_template branch from 4545bb5 to 3113e03 Compare October 25, 2023 10:55
@github-actions github-actions bot added size/XL and removed size/L labels Oct 25, 2023
@github-actions
Copy link

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

1 similar comment
@github-actions
Copy link

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

@Zippo-Wang Zippo-Wang force-pushed the migrate_DDS-parameter_template branch from 3113e03 to e995244 Compare October 26, 2023 01:37
@github-actions
Copy link

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

1 similar comment
@github-actions
Copy link

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

@chengxiangdong
Copy link
Contributor

/lgtm

@github-actions github-actions bot added the LGTM label Nov 21, 2023
chengxiangdong
chengxiangdong reviewed Nov 25, 2023
View reviewed changes
flexibleengine/provider.go Show resolved Hide resolved
flexibleengine/provider.go Show resolved Hide resolved
docs/data-sources/dds_instances.md Show resolved Hide resolved
docs/resources/dds_audit_log_policy.md Show resolved Hide resolved
docs/resources/dds_backup.md Show resolved Hide resolved
docs/resources/dds_parameter_template.md Show resolved Hide resolved
@Zippo-Wang Zippo-Wang force-pushed the migrate_DDS-parameter_template branch from e995244 to eeee185 Compare November 25, 2023 09:09
@github-actions github-actions bot removed the LGTM label Nov 25, 2023
@github-actions GitHub Actions
Copy link

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

@Zippo-Wang Zippo-Wang force-pushed the migrate_DDS-parameter_template branch from eeee185 to f8d7ba3 Compare November 25, 2023 09:13
@github-actions GitHub Actions
Copy link

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

@Zippo-Wang Zippo-Wang force-pushed the migrate_DDS-parameter_template branch from 423eeb9 to 99c702a Compare November 25, 2023 09:32
@github-actions GitHub Actions
Copy link

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

@Zippo-Wang Zippo-Wang force-pushed the migrate_DDS-parameter_template branch 3 times, most recently from 99c702a to 6d2d5c4 Compare November 25, 2023 09:36
@github-actions GitHub Actions
Copy link

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

@chengxiangdong
Copy link
Contributor

/lgtm

@github-actions github-actions bot added the LGTM label Nov 27, 2023
@chengxiangdong
Copy link
Contributor

/approve

@Zippo-Wang Zippo-Wang force-pushed the migrate_DDS-parameter_template branch from 6d2d5c4 to 63e5423 Compare December 1, 2023 09:48
@github-actions github-actions bot removed the LGTM label Dec 1, 2023
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 1, 2023

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

@Zippo-Wang Zippo-Wang force-pushed the migrate_DDS-parameter_template branch from 63e5423 to a037984 Compare December 25, 2023 01:54
@github-actions GitHub Actions
Copy link

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

@Zippo-Wang Zippo-Wang force-pushed the migrate_DDS-parameter_template branch from a037984 to b359171 Compare December 25, 2023 03:14
@github-actions GitHub Actions
Copy link

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

@Zippo-Wang Zippo-Wang force-pushed the migrate_DDS-parameter_template branch from b359171 to 8b08ab2 Compare December 25, 2023 03:42
@github-actions GitHub Actions
Copy link

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

@ShiChangkuo ShiChangkuo merged commit 1be36a6 into FlexibleEngineCloud:master Dec 25, 2023
6 checks passed
@Zippo-Wang Zippo-Wang deleted the migrate_DDS-parameter_template branch December 25, 2023 06:11
Zippo-Wang added a commit to Zippo-Wang/terraform-provider-flexibleengine that referenced this pull request Jan 3, 2024
@Zippo-Wang
feat(DDS): import DDS resource, unit test and document (FlexibleEngin…
89515ef 
…eCloud#1039)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chengxiangdong chengxiangdong chengxiangdong left review comments

@github-actions github-actions[bot] github-actions[bot] approved these changes

Assignees
No one assigned
Labels
approved feature LGTM size/XL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Zippo-Wang @chengxiangdong @ShiChangkuo