Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ECS): import ECS resource, unit test and document. #1037

Merged
merged 1 commit into from
Nov 1, 2023
Merged

feat(ECS): import ECS resource, unit test and document. #1037

merged 1 commit into from
Nov 1, 2023

Conversation

Zippo-Wang
Copy link
Contributor

@Zippo-Wang Zippo-Wang commented Oct 11, 2023 •
edited
Loading

What this PR does / why we need it:
import data_source_flexibleengine_compute_servergroups resource, unit test and document

Which issue this PR fixes:
(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)
fixes #xxx

Special notes for your reviewer:

Release note:

PR Checklist

  • Tests added/passed.
  • Documentation updated.
  • Schema updated.

Acceptance Steps Performed

=== RUN   TestAccComputeServerGroupsDataSource_basic
=== PAUSE TestAccComputeServerGroupsDataSource_basic
=== CONT  TestAccComputeServerGroupsDataSource_basic
--- PASS: TestAccComputeServerGroupsDataSource_basic (81.96s)
PASS

coverage: 2.0% of statements in ../../../terraform-provider-flexibleengine/...

chengxiangdong
chengxiangdong reviewed Oct 18, 2023
View reviewed changes
Copy link
Contributor

@chengxiangdong chengxiangdong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The dataSource or resource should be sorted in ascending alphabetical order, or created near an existing resource.

flexibleengine/provider.go Outdated Show resolved Hide resolved
flexibleengine/provider.go Show resolved Hide resolved
flexibleengine/provider.go Outdated Show resolved Hide resolved
@Zippo-Wang Zippo-Wang force-pushed the migrate_ECS-compute_servergroups branch from e4f9005 to f0911ea Compare October 18, 2023 08:38
@github-actions github-actions bot added size/S and removed size/M labels Oct 18, 2023
@Zippo-Wang
feat(ECS): import ECS resource, unit test and document.
67e77bb 
### resourceName: data_source_flexibleengine_compute_servergroups
@Zippo-Wang Zippo-Wang force-pushed the migrate_ECS-compute_servergroups branch from f0911ea to 67e77bb Compare October 18, 2023 08:40
@chengxiangdong
Copy link
Contributor

/lgtm

@github-actions github-actions bot added the LGTM label Oct 19, 2023
@ShiChangkuo ShiChangkuo merged commit 1b0a3a4 into FlexibleEngineCloud:master Nov 1, 2023
4 checks passed
@Zippo-Wang Zippo-Wang deleted the migrate_ECS-compute_servergroups branch November 1, 2023 07:15
Zippo-Wang added a commit to Zippo-Wang/terraform-provider-flexibleengine that referenced this pull request Nov 10, 2023
@Zippo-Wang
feat(ECS): add compute_servergroups data source (FlexibleEngineCloud#…
d20c6b1 
…1037)
Zhukun-Huawei pushed a commit to Zhukun-Huawei/terraform-provider-flexibleengine that referenced this pull request Nov 20, 2023
@Zippo-Wang @Zhukun-Huawei
feat(ECS): add compute_servergroups data source (FlexibleEngineCloud#…
eb3beec 
…1037)
Zhukun-Huawei pushed a commit to Zhukun-Huawei/terraform-provider-flexibleengine that referenced this pull request Nov 20, 2023
@Zippo-Wang @Zhukun-Huawei
feat(ECS): add compute_servergroups data source (FlexibleEngineCloud#…
0d849f3 
…1037)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chengxiangdong chengxiangdong chengxiangdong left review comments

Assignees
No one assigned
Labels
feature LGTM size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Zippo-Wang @chengxiangdong @ShiChangkuo