docs: fix docs of vpc_v1 #1021

Zhukun-Huawei · 2023-09-22T09:13:14Z

docs: fix docs of vpc_v1

chengxiangdong · 2023-10-13T04:54:42Z

docs/data-sources/networking_port.md

The attribute all_allowed_ips is missing.

Done, I have added the attribute all_allowed_ips

chengxiangdong · 2023-10-13T04:56:44Z

docs/resources/networking_secgroup_rule_v2.md

In this doc, the field type and ForceNew are missing, please complete them.

chengxiangdong · 2023-10-13T04:58:09Z

docs/data-sources/networking_port.md

+* `admin_state_up` - The administrative state of the port.
+
+* `device_id` - The ID of the device the port belongs to.
+
+* `device_owner` - The device owner of the port.
+
+* `name` - The name of the port.
+


Please move them after the region field.

Done, I have moved region field to the first position

please move the attribute into Attributes Reference

please move the attribute into Attributes Reference

done

chengxiangdong · 2023-10-13T04:58:49Z

docs/data-sources/vpc_peering_connection_v2.md

The field types in this document are missing, please complete them.

chengxiangdong · 2023-10-13T04:59:56Z

docs/data-sources/vpc_route_ids_v2.md

+* `region` - (Optional) The region in which to obtain the V1 VPC client. A VPC client is needed to retrieve VPCs.
+  If omitted, the region argument of the provider is used.
+


The argument region is usually in the first position.

chengxiangdong · 2023-10-13T05:20:25Z

docs/resources/vpcep_approval.md

+* `region` - The region in which to obtain the VPC endpoint service.
+


Suggested change

* `region` - The region in which to obtain the VPC endpoint service.

* `region` - (Optional, String, ForceNew) The region in which to create the resource.

If omitted, the provider-level region will be used. Changing this creates a new resource.

Please move it to the first position in the parameter

chengxiangdong · 2023-10-13T05:21:30Z

docs/resources/vpcep_endpoint.md

@@ -104,14 +104,14 @@ The following arguments are supported:

 * `tags` - (Optional) The key/value pairs to associate with the VPC endpoint.

+* `region` - The region in which to create the VPC endpoint.


Suggested change

* `region` - The region in which to create the VPC endpoint.

* `region` - (Optional, String, ForceNew) The region in which to create the resource.

If omitted, the provider-level region will be used. Changing this creates a new resource.

Please move it to the first position in the parameter

chengxiangdong · 2023-10-13T05:21:59Z

docs/resources/vpcep_endpoint.md

In this docs, the field type and ForceNew properties are missing, please fill them in.

Done, the field type and ForceNew label are added

chengxiangdong · 2023-10-13T05:22:11Z

docs/resources/vpcep_approval.md

In this docs, the field type and ForceNew properties are missing, please fill them in.

Done, the field type and ForceNew label are added

chengxiangdong · 2023-10-13T05:22:31Z

docs/resources/vpcep_service.md

In this docs, the field type and ForceNew properties are missing, please fill them in.

The argument region is usually in the first position.

Done, the field type and ForceNew label are added

chengxiangdong · 2023-11-24T09:54:18Z

/lgtm

ShiChangkuo · 2023-11-24T10:14:26Z

docs/resources/vpcep_service.md

    This port is provided by the VPC endpoint, allowing you to access the VPC endpoint service.
    The value ranges from 1 to 65535.

+* `service_type` - (Required, String, ForceNew)The type of the VPC endpoint service. Only **interface** can be configured.


service_type is optional in schema, please check it carefully.

chengxiangdong · 2023-11-27T06:45:39Z

docs/resources/vpc_route_v2.md

  Changing this creates a new Route.

-* `vpc_id` (Required) - Specifies the VPC for which a route is to be added. Changing this creates a new Route.
+* `nexthop` (Required, String) - Specifies the next hop.


Suggested change

* `nexthop` (Required, String) - Specifies the next hop.

* `nexthop` (Required, String, ForceNew) - Specifies the next hop.

chengxiangdong · 2023-11-27T06:45:50Z

docs/resources/vpc_route_v2.md

+  If the route type is peering, enter the VPC peering connection ID.
+  Changing this creates a new Route.
+
+* `type` (Required, String) - Specifies the route type. Currently, the value can only be **peering**.


Suggested change

* `type` (Required, String) - Specifies the route type. Currently, the value can only be **peering**.

* `type` (Required, String, ForceNew) - Specifies the route type. Currently, the value can only be **peering**.

done, revised

chengxiangdong · 2023-11-27T06:46:03Z

docs/resources/vpc_route_v2.md


-* `tenant_id` (Optional) - Specifies the tenant ID. Only the administrator can specify the tenant ID of other tenant.
+* `tenant_id` (Optional, String) - Specifies the tenant ID. Only the administrator can specify the tenant ID of other tenant.


Suggested change

* `tenant_id` (Optional, String) - Specifies the tenant ID. Only the administrator can specify the tenant ID of other tenant.

* `tenant_id` (Optional, String, ForceNew) - Specifies the tenant ID. Only the administrator can specify the tenant ID of other tenant.

done, revised

chengxiangdong · 2023-11-27T06:47:44Z

docs/resources/vpc_flow_log_v1.md

traffic_type does not support updates, please add ForceNew

pls remove status

has already added

status should be kept

chengxiangdong · 2023-11-27T07:04:50Z

docs/resources/vpcep_endpoint.md

    Changing this creates a new VPC endpoint.

-* `enable_whitelist` (Optional) - Specifies whether to enable access control. The default value is false.
+* `enable_whitelist` (Optional, Bool) - Specifies whether to enable access control. The default value is false.


Suggested change

* `enable_whitelist` (Optional, Bool) - Specifies whether to enable access control. The default value is false.

* `enable_whitelist` (Optional, Bool, ForceNew) - Specifies whether to enable access control. The default value is false.

chengxiangdong · 2023-11-27T07:05:10Z

docs/resources/vpcep_endpoint.md

    Changing this creates a new VPC endpoint.

-* `whitelist` (Optional) - Specifies the list of IP address or CIDR block which can be accessed to the VPC endpoint.
+* `whitelist` (Optional, List) - Specifies the list of IP address or CIDR block which can be accessed to the VPC endpoint.


Suggested change

* `whitelist` (Optional, List) - Specifies the list of IP address or CIDR block which can be accessed to the VPC endpoint.

* `whitelist` (Optional, List, ForceNew) - Specifies the list of IP address or CIDR block which can be accessed to the VPC endpoint.

chengxiangdong · 2023-11-27T07:28:15Z

docs/data-sources/vpc_peering_connection_v2.md

pls remove attribute description

chengxiangdong · 2023-11-27T07:30:59Z

docs/data-sources/vpc_route_v2.md

pls move nexthop to argument.

done, revised

chengxiangdong · 2023-11-27T07:32:06Z

docs/data-sources/vpc_subnet_v1.md

@@ -57,6 +60,8 @@ the selected subnet.

 * `dhcp_enable` - DHCP function for the subnet.

+* `description` - The description of the subnet.


pls move description to argument

done, revised

chengxiangdong · 2023-11-28T10:37:51Z

/lgtm
/approve

docs/data-sources/vpc_v1.md

github-actions bot added the size/XS label Sep 22, 2023

Zhukun-Huawei force-pushed the personalbranch branch from c335ffb to c02226a Compare September 22, 2023 09:20

github-actions bot added the documentation label Sep 22, 2023

Zhukun-Huawei changed the title ~~修复vpc_v1的文档, 添加timeouts~~ docs: fix docs of vpc_v1, increase timeouts information Sep 22, 2023

Zhukun-Huawei force-pushed the personalbranch branch from c02226a to 44abdb5 Compare September 22, 2023 10:04

Zhukun-Huawei changed the title ~~docs: fix docs of vpc_v1, increase timeouts information~~ docs: fix docs of vpc_v1 Sep 22, 2023

Zhukun-Huawei force-pushed the personalbranch branch 2 times, most recently from 2391db9 to 29df528 Compare September 25, 2023 12:28

github-actions bot added size/S and removed size/XS labels Sep 25, 2023

Zhukun-Huawei force-pushed the personalbranch branch 5 times, most recently from 5995b3d to c1468b3 Compare September 28, 2023 07:22

github-actions bot added size/M and removed size/S labels Sep 28, 2023

Zhukun-Huawei force-pushed the personalbranch branch from c1468b3 to 15f94ff Compare September 28, 2023 09:19

Zhukun-Huawei force-pushed the personalbranch branch 6 times, most recently from 36a8a3d to b09ea20 Compare October 7, 2023 09:18

chengxiangdong suggested changes Oct 13, 2023

View reviewed changes

Zhukun-Huawei force-pushed the personalbranch branch from 6536034 to 17dfb67 Compare October 24, 2023 08:34

Zhukun-Huawei force-pushed the personalbranch branch from 17dfb67 to ee667ef Compare November 21, 2023 07:17

github-actions bot added size/XS and removed size/M labels Nov 21, 2023

Zhukun-Huawei force-pushed the personalbranch branch from ee667ef to 0ff230e Compare November 21, 2023 07:52

github-actions bot added the LGTM label Nov 24, 2023

Zhukun-Huawei force-pushed the personalbranch branch from d107d5a to bf2a736 Compare November 24, 2023 08:47

github-actions bot removed the LGTM label Nov 24, 2023

Zhukun-Huawei force-pushed the personalbranch branch 2 times, most recently from fd0cfde to a73b13d Compare November 24, 2023 09:08

github-actions bot added the LGTM label Nov 24, 2023

ShiChangkuo reviewed Nov 24, 2023

View reviewed changes

Zhukun-Huawei force-pushed the personalbranch branch from a73b13d to 2bcee45 Compare November 25, 2023 02:59

github-actions bot removed the LGTM label Nov 25, 2023

chengxiangdong reviewed Nov 27, 2023

View reviewed changes

Zhukun-Huawei force-pushed the personalbranch branch 7 times, most recently from 707509d to 1b83a02 Compare November 28, 2023 10:31

docs: fix docs of vpc

f7a0a9b

Zhukun-Huawei force-pushed the personalbranch branch from 1b83a02 to f7a0a9b Compare November 28, 2023 10:33

github-actions bot added the LGTM label Nov 28, 2023

github-actions bot approved these changes Nov 28, 2023

View reviewed changes

github-actions bot added the approved label Nov 28, 2023

ShiChangkuo reviewed Dec 1, 2023

View reviewed changes

docs/data-sources/vpc_v1.md Outdated Show resolved Hide resolved

Update docs/data-sources/vpc_v1.md

0e0176b

github-actions bot removed the LGTM label Dec 1, 2023

ShiChangkuo merged commit 1173ff8 into FlexibleEngineCloud:master Dec 1, 2023
5 checks passed

Zippo-Wang pushed a commit to Zippo-Wang/terraform-provider-flexibleengine that referenced this pull request Dec 25, 2023

docs(vpc): fix docs of vpc service (FlexibleEngineCloud#1021)

53210b4

Zhukun-Huawei deleted the personalbranch branch December 26, 2023 13:14

		* `region` - (Optional) The region in which to obtain the V1 VPC client. A VPC client is needed to retrieve VPCs.
		If omitted, the region argument of the provider is used.

		* `region` - The region in which to obtain the VPC endpoint service.

	* `region` - The region in which to obtain the VPC endpoint service.
	* `region` - (Optional, String, ForceNew) The region in which to create the resource.
	If omitted, the provider-level region will be used. Changing this creates a new resource.

		@@ -104,14 +104,14 @@ The following arguments are supported:

		* `tags` - (Optional) The key/value pairs to associate with the VPC endpoint.

		* `region` - The region in which to create the VPC endpoint.

	* `nexthop` (Required, String) - Specifies the next hop.
	* `nexthop` (Required, String, ForceNew) - Specifies the next hop.

	* `type` (Required, String) - Specifies the route type. Currently, the value can only be peering.
	* `type` (Required, String, ForceNew) - Specifies the route type. Currently, the value can only be peering.


		* `tenant_id` (Optional) - Specifies the tenant ID. Only the administrator can specify the tenant ID of other tenant.
		* `tenant_id` (Optional, String) - Specifies the tenant ID. Only the administrator can specify the tenant ID of other tenant.

	* `tenant_id` (Optional, String) - Specifies the tenant ID. Only the administrator can specify the tenant ID of other tenant.
	* `tenant_id` (Optional, String, ForceNew) - Specifies the tenant ID. Only the administrator can specify the tenant ID of other tenant.

	* `enable_whitelist` (Optional, Bool) - Specifies whether to enable access control. The default value is false.
	* `enable_whitelist` (Optional, Bool, ForceNew) - Specifies whether to enable access control. The default value is false.

	* `whitelist` (Optional, List) - Specifies the list of IP address or CIDR block which can be accessed to the VPC endpoint.
	* `whitelist` (Optional, List, ForceNew) - Specifies the list of IP address or CIDR block which can be accessed to the VPC endpoint.

		@@ -57,6 +60,8 @@ the selected subnet.

		* `dhcp_enable` - DHCP function for the subnet.

		* `description` - The description of the subnet.

docs: fix docs of vpc_v1 #1021

docs: fix docs of vpc_v1 #1021

Conversation

Zhukun-Huawei commented Sep 22, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

chengxiangdong commented Nov 24, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Zhukun-Huawei Nov 27, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Zhukun-Huawei Nov 27, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Zhukun-Huawei Nov 27, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Zhukun-Huawei Nov 27, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Zhukun-Huawei Nov 27, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Zhukun-Huawei Nov 27, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Zhukun-Huawei Nov 27, 2023 • edited Loading

Choose a reason for hiding this comment

chengxiangdong commented Nov 28, 2023

Zhukun-Huawei commented Sep 22, 2023 •

edited

Loading

Zhukun-Huawei Nov 27, 2023 •

edited

Loading

Zhukun-Huawei Nov 27, 2023 •

edited

Loading

Zhukun-Huawei Nov 27, 2023 •

edited

Loading

Zhukun-Huawei Nov 27, 2023 •

edited

Loading

Zhukun-Huawei Nov 27, 2023 •

edited

Loading

Zhukun-Huawei Nov 27, 2023 •

edited

Loading

Zhukun-Huawei Nov 27, 2023 •

edited

Loading