Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Identity alias #4620

Merged
merged 18 commits into from
Oct 2, 2024
Merged

feat: Identity alias #4620

merged 18 commits into from
Oct 2, 2024

Conversation

kyle-ssg
Copy link
Member

@kyle-ssg kyle-ssg commented Sep 11, 2024

Thanks for submitting a PR! Please check the boxes below:

  • I have added information to docs/ if required so people know about the feature!
  • I have filled in the "Changes" section below?
  • I have filled in the "How did you test this code" section below?
  • I have used a Conventional Commit title for this Pull Request

Changes

  • Allows you to specify an alias for identities
  • The flagsmith app will now start identifying by id rather than email

How did you test this code?

image

GIF Recording 2024-09-17 at 4 36 58 PM
_

@kyle-ssg kyle-ssg requested a review from a team as a code owner September 11, 2024 13:54
Copy link

vercel bot commented Sep 11, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
flagsmith-frontend-preview ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 2, 2024 3:00pm
flagsmith-frontend-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 2, 2024 3:00pm
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
docs ⬜️ Ignored (Inspect) Visit Preview Oct 2, 2024 3:00pm

@kyle-ssg kyle-ssg marked this pull request as draft September 11, 2024 13:54
@github-actions github-actions bot added front-end Issue related to the React Front End Dashboard feature New feature or request labels Sep 11, 2024
Copy link
Contributor

github-actions bot commented Sep 11, 2024

Docker builds report

Image Build Status Security report
ghcr.io/flagsmith/flagsmith-api-test:pr-4620 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-e2e:pr-4620 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-api:pr-4620 Finished ✅ Results
ghcr.io/flagsmith/flagsmith:pr-4620 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-private-cloud:pr-4620 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-frontend:pr-4620 Finished ✅ Results

Copy link
Contributor

github-actions bot commented Sep 11, 2024

Uffizzi Preview deployment-56166 was deleted.

@github-actions github-actions bot added feature New feature or request and removed feature New feature or request labels Sep 11, 2024
@github-actions github-actions bot added feature New feature or request and removed feature New feature or request labels Sep 11, 2024
@kyle-ssg kyle-ssg requested review from rolodato and matthewelwell and removed request for rolodato September 11, 2024 14:39
Copy link

flagsmith bot commented Oct 2, 2024

Flagsmith Feature identity_aliases has been updated:

Segment flagsmith_team values:

Environment Enabled Value Last Updated (UTC)
Production ❌ Disabled 2024-10-02 14:07:22

Copy link
Contributor

@matthewelwell matthewelwell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm approving this. The only remaining thing I noticed was that we still show the alias on the list page even when the flag is disabled.

I don't see this as a particular issue, since it's obviously not possible to set an alias without the flag being enabled, but it might be odd if we subsequently want to turn the flag off again in a future situation.

Copy link

flagsmith bot commented Oct 2, 2024

Flagsmith Feature identity_aliases has been updated:

Segment flagsmith_team values:

Environment Enabled Value Last Updated (UTC)
Production ✅ Enabled 2024-10-02 14:16:05

@github-actions github-actions bot added feature New feature or request and removed feature New feature or request labels Oct 2, 2024
@kyle-ssg kyle-ssg added this pull request to the merge queue Oct 2, 2024
Merged via the queue into main with commit d18049b Oct 2, 2024
31 checks passed
@kyle-ssg kyle-ssg deleted the feat/identity-alias branch October 2, 2024 15:03
Copy link

flagsmith bot commented Oct 2, 2024

Flagsmith Feature identity_aliases has been updated:

Environment Enabled Value Last Updated (UTC)
Demo ✅ Enabled 2024-10-02 16:01:54

Copy link

flagsmith bot commented Oct 4, 2024

Flagsmith Feature identity_aliases has been updated:

Segment org_segment_skai values:

Environment Enabled Value Last Updated (UTC)
Production ✅ Enabled 2024-10-04 08:41:33

Copy link

flagsmith bot commented Oct 9, 2024

Flagsmith Feature identity_aliases has been updated:

Segment org_segment_wistia values:

Environment Enabled Value Last Updated (UTC)
Production ✅ Enabled 2024-10-09 14:38:18

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request front-end Issue related to the React Front End Dashboard
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve search and display capabilities for identities in the Flagsmith UI
2 participants