-
Notifications
You must be signed in to change notification settings - Fork 406
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Identity alias #4620
feat: Identity alias #4620
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
Docker builds report
|
Uffizzi Preview |
Flagsmith Feature Segment
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm approving this. The only remaining thing I noticed was that we still show the alias on the list page even when the flag is disabled.
I don't see this as a particular issue, since it's obviously not possible to set an alias without the flag being enabled, but it might be odd if we subsequently want to turn the flag off again in a future situation.
Flagsmith Feature Segment
|
Flagsmith Feature
|
Flagsmith Feature Segment
|
Flagsmith Feature Segment
|
Thanks for submitting a PR! Please check the boxes below:
docs/
if required so people know about the feature!Changes
How did you test this code?
_