-
Notifications
You must be signed in to change notification settings - Fork 406
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Copy ACS URL for SAML configurations to clipboard. Disable editing SAML configuration names #4494
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
github-actions
bot
added
front-end
Issue related to the React Front End Dashboard
api
Issue related to the REST API
docs
Documentation updates
labels
Aug 13, 2024
rolodato
added
feature
New feature or request
and removed
api
Issue related to the REST API
docs
Documentation updates
labels
Aug 13, 2024
github-actions
bot
added
feature
New feature or request
and removed
feature
New feature or request
labels
Aug 13, 2024
rolodato
changed the title
feat: Copy ACS URL for SAML configurations
feat: Copy ACS URL for SAML configurations to clipboard
Aug 13, 2024
rolodato
force-pushed
the
feat/copy-acs-url
branch
from
August 13, 2024 21:12
0660ee4
to
32cbb00
Compare
github-actions
bot
added
docs
Documentation updates
feature
New feature or request
and removed
feature
New feature or request
docs
Documentation updates
labels
Aug 13, 2024
Uffizzi Preview |
rolodato
changed the title
feat: Copy ACS URL for SAML configurations to clipboard
feat: Copy ACS URL for SAML configurations to clipboard. Disable editing SAML configuration names
Aug 13, 2024
kyle-ssg
approved these changes
Aug 14, 2024
github-actions
bot
added
docs
Documentation updates
feature
New feature or request
and removed
feature
New feature or request
docs
Documentation updates
labels
Aug 14, 2024
github-actions
bot
added
feature
New feature or request
and removed
feature
New feature or request
docs
Documentation updates
labels
Aug 19, 2024
Moved the ACS URL into the edit modal - not too happy with the styling but it's an improvement over what we have now in prod for sure saml.new.mov |
github-actions
bot
added
feature
New feature or request
and removed
feature
New feature or request
labels
Aug 19, 2024
Docker builds report
|
@kyle-ssg could I bother you again with a quick review on this? 🙏 |
zachaysan
approved these changes
Aug 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for submitting a PR! Please check the boxes below:
docs/
if required so people know about the feature!Changes
Disable editing SAML configuration name
Changing a SAML configuration name has the following effects:
Preventing changes to the configuration name from the UI prevents these footguns, while still leaving an escape hatch open to change names from the API or Django Admin. A better solution would be to use fixed SAML configuration IDs (e.g. numbers) in the ACS URLs instead of the configuration name, but this is a good stopgap until we can implement that. For example:
instead of
Add button to copy ACS URL
The ACS URL is only currently available in documentation and requires figuring out the API URL and manually building the URL, remembering to include trailing slashes, etc. This PR adds a button to copy the correct URL.
I decided to add a button in the list of configurations instead of showing the full URL inside the edit modal because it's easier to implement.
Unfinished: The API URL used is just whatever URL is configured for Flagsmith-on-Flagsmith. For example, in my dev environment this resolves to
https://api.flagsmith.com/api/v1/
but should behttp://localhost:8000/api/v1/
. I haven't figured out how to get the correct URL yet.This still looks bad but works:
How did you test this code?
Manually - create a SAML configuration and look at it from the frontend.