Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Rename match variable in external feature resources #4490

Merged

Conversation

novakzaballa
Copy link
Contributor

Thanks for submitting a PR! Please check the boxes below:

  • I have added information to docs/ if required so people know about the feature!
  • I have filled in the "Changes" section below?
  • I have filled in the "How did you test this code" section below?
  • I have used a Conventional Commit title for this Pull Request

Changes

Rename match variable to url_match

How did you test this code?

Already exists unit tests

@novakzaballa novakzaballa requested a review from a team as a code owner August 13, 2024 13:19
@novakzaballa novakzaballa requested review from zachaysan and removed request for a team August 13, 2024 13:20
@github-actions github-actions bot added the api Issue related to the REST API label Aug 13, 2024
Copy link

vercel bot commented Aug 13, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs ⬜️ Ignored (Inspect) Aug 13, 2024 1:20pm
flagsmith-frontend-preview ⬜️ Ignored (Inspect) Aug 13, 2024 1:20pm
flagsmith-frontend-staging ⬜️ Ignored (Inspect) Aug 13, 2024 1:20pm

@github-actions github-actions bot added the fix label Aug 13, 2024
Copy link
Contributor

github-actions bot commented Aug 13, 2024

Docker builds report

Image Build Status Security report
ghcr.io/flagsmith/flagsmith-e2e:pr-4490 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-api-test:pr-4490 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-frontend:pr-4490 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-api:pr-4490 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-private-cloud:pr-4490 Finished ✅ Results
ghcr.io/flagsmith/flagsmith:pr-4490 Finished ✅ Results

Copy link
Contributor

github-actions bot commented Aug 13, 2024

Uffizzi Preview deployment-55206 was deleted.

Copy link

codecov bot commented Aug 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.91%. Comparing base (36e634c) to head (e02fe25).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4490   +/-   ##
=======================================
  Coverage   96.91%   96.91%           
=======================================
  Files        1176     1176           
  Lines       39349    39349           
=======================================
  Hits        38135    38135           
  Misses       1214     1214           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@novakzaballa novakzaballa added this pull request to the merge queue Aug 13, 2024
Merged via the queue into main with commit bf82b9d Aug 13, 2024
35 checks passed
@novakzaballa novakzaballa deleted the fix/rename-match-variable-in-external-feature-resource branch August 13, 2024 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api Issue related to the REST API fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants