Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Tweak email wording for grace periods #4482

Merged
merged 4 commits into from
Aug 13, 2024

Conversation

zachaysan
Copy link
Contributor

Changes

Adds in a grace period check on the language around API usage notifications.

How did you test this code?

Altered an existing test.

@zachaysan zachaysan requested a review from a team as a code owner August 12, 2024 18:49
@zachaysan zachaysan requested review from novakzaballa and removed request for a team August 12, 2024 18:49
Copy link

vercel bot commented Aug 12, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs ⬜️ Ignored (Inspect) Aug 12, 2024 6:51pm
flagsmith-frontend-preview ⬜️ Ignored (Inspect) Aug 12, 2024 6:51pm
flagsmith-frontend-staging ⬜️ Ignored (Inspect) Aug 12, 2024 6:51pm

@github-actions github-actions bot added api Issue related to the REST API feature New feature or request labels Aug 12, 2024
Copy link
Contributor

github-actions bot commented Aug 12, 2024

Docker builds report

Image Build Status Security report
ghcr.io/flagsmith/flagsmith-frontend:pr-4482 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-api-test:pr-4482 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-e2e:pr-4482 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-api:pr-4482 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-api:pr-4482 Finished ✅ Results
ghcr.io/flagsmith/flagsmith:pr-4482 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-frontend:pr-4482 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-private-cloud:pr-4482 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-private-cloud:pr-4482 Finished ✅ Results
ghcr.io/flagsmith/flagsmith:pr-4482 Finished ✅ Results

@github-actions github-actions bot added feature New feature or request and removed feature New feature or request labels Aug 12, 2024
Copy link
Contributor

github-actions bot commented Aug 12, 2024

Uffizzi Preview deployment-55180 was deleted.

Copy link

codecov bot commented Aug 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.91%. Comparing base (6660af5) to head (0dd3322).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4482   +/-   ##
=======================================
  Coverage   96.91%   96.91%           
=======================================
  Files        1176     1176           
  Lines       39348    39348           
=======================================
  Hits        38134    38134           
  Misses       1214     1214           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@matthewelwell matthewelwell added this pull request to the merge queue Aug 13, 2024
Merged via the queue into main with commit 36e634c Aug 13, 2024
35 checks passed
@matthewelwell matthewelwell deleted the feat/tweak_email_wording_for_grace_periods branch August 13, 2024 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api Issue related to the REST API feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants