Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ensure that usage notification logic is independent of other organisations notifications #4480

Merged
merged 1 commit into from
Aug 12, 2024

Conversation

matthewelwell
Copy link
Contributor

Changes

Fixes an issue where usage notifications weren't sent if another organisation had been notified in the same billing period.

How did you test this code?

Updated an existing test. Watched the test fail before adding the fix and watching it pass.

@matthewelwell matthewelwell requested a review from a team as a code owner August 12, 2024 15:24
Copy link

vercel bot commented Aug 12, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs ⬜️ Ignored (Inspect) Aug 12, 2024 3:24pm
flagsmith-frontend-preview ⬜️ Ignored (Inspect) Aug 12, 2024 3:24pm
flagsmith-frontend-staging ⬜️ Ignored (Inspect) Aug 12, 2024 3:24pm

@github-actions github-actions bot added api Issue related to the REST API fix labels Aug 12, 2024
Copy link
Contributor

github-actions bot commented Aug 12, 2024

Docker builds report

Image Build Status Security report
ghcr.io/flagsmith/flagsmith-api-test:pr-4480 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-e2e:pr-4480 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-frontend:pr-4480 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-api:pr-4480 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-private-cloud:pr-4480 Finished ✅ Results
ghcr.io/flagsmith/flagsmith:pr-4480 Finished ✅ Results

Copy link
Contributor

github-actions bot commented Aug 12, 2024

Uffizzi Preview deployment-55166 was deleted.

@matthewelwell matthewelwell added this pull request to the merge queue Aug 12, 2024
Merged via the queue into main with commit 6660af5 Aug 12, 2024
33 checks passed
@matthewelwell matthewelwell deleted the fix/api-usage-notification-filters-on-all-orgs branch August 12, 2024 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api Issue related to the REST API fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants