Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Remove warning about non-unique health namespace #4479

Merged
merged 1 commit into from
Aug 12, 2024

Conversation

rolodato
Copy link
Member

Thanks for submitting a PR! Please check the boxes below:

  • I have added information to docs/ if required so people know about the feature!
  • I have filled in the "Changes" section below?
  • I have filled in the "How did you test this code" section below?
  • I have used a Conventional Commit title for this Pull Request

Changes

Fixes a warning about non-unique namespaces, can be seen when API starts up:

WARNINGS:
?: (urls.W005) URL namespace 'health' isn't unique. You may not be able to reverse all URLs in this namespace

Forgot to add this before merging #4340

How did you test this code?

python manage.py runserver, warning is no longer there

Fixes a warning about non-unique namespaces
@rolodato rolodato requested a review from a team as a code owner August 12, 2024 14:21
@rolodato rolodato requested review from gagantrivedi and removed request for a team August 12, 2024 14:21
Copy link

vercel bot commented Aug 12, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs ⬜️ Ignored (Inspect) Aug 12, 2024 2:21pm
flagsmith-frontend-preview ⬜️ Ignored (Inspect) Aug 12, 2024 2:21pm
flagsmith-frontend-staging ⬜️ Ignored (Inspect) Aug 12, 2024 2:21pm

@github-actions github-actions bot added the api Issue related to the REST API label Aug 12, 2024
Copy link
Contributor

github-actions bot commented Aug 12, 2024

Docker builds report

Image Build Status Security report
ghcr.io/flagsmith/flagsmith-e2e:pr-4479 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-api-test:pr-4479 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-frontend:pr-4479 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-api:pr-4479 Finished ✅ Results
ghcr.io/flagsmith/flagsmith:pr-4479 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-private-cloud:pr-4479 Finished ✅ Results

@github-actions github-actions bot added the fix label Aug 12, 2024
Copy link
Contributor

github-actions bot commented Aug 12, 2024

Uffizzi Preview deployment-55163 was deleted.

@rolodato rolodato added this pull request to the merge queue Aug 12, 2024
Merged via the queue into main with commit 6ef7a74 Aug 12, 2024
33 checks passed
@rolodato rolodato deleted the fix/aptible-healthcheck-warn branch August 12, 2024 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api Issue related to the REST API fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants